Date: Tue, 8 Oct 2002 18:03:09 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: Alfred Perlstein <bright@mu.org>, emulation@FreeBSD.org, audit@FreeBSD.org Subject: Re: Linuxlator patches for review [was: Who currently maintains Linuxlator?] Message-ID: <20021009010309.GA607@dhcp01.pn.xcllnt.net> In-Reply-To: <3DA2BE32.BDEC28B5@FreeBSD.org> References: <20021006110243.GA70993@vega.vega.com> <20021006183650.GY95327@elvis.mu.org> <3DA2BE32.BDEC28B5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 08, 2002 at 02:14:58PM +0300, Maxim Sobolev wrote: > See attached. As it was suggested, I'm also CC'ing marcel, > freebsd-audit and freebsd-emulation. I'd like to hear any suggestion > or comments. Please note that changes were not tested on alpha, > because I don't have any axp hardware. I can test on Alpha, provided the patch is against -current. Do you have some test cases? > /* > + * VFAT > + */ > +#define LINUX_VFAT_READDIR_BOTH 0x7201 > + > +#define LINUX_IOCTL_VFAT_MIN LINUX_VFAT_READDIR_BOTH > +#define LINUX_IOCTL_VFAT_MAX LINUX_VFAT_READDIR_BOTH > + > +/* Silly question: The VFAT ioctl is not implemented. Is there a bigger picture? Also: is it worth having a VFAT handler if there's only 1 ioctl (again, there might be a bigger picture)? > case LINUX_IPC_INFO: > case LINUX_SEM_INFO: > - error = copyin((caddr_t)args->arg.buf, &linux_seminfo, > - sizeof(linux_seminfo) ); > - if (error) > - return error; > bcopy(&seminfo, &linux_seminfo, sizeof(linux_seminfo) ); > /* XXX BSD equivalent? > #define used_semids 10 Should the copyin be replaced with something or was the copyin bogus? Other than that: looks good. I merely skimmed over it, so I may have missed a detail.... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-emulation" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021009010309.GA607>