From nobody Wed Jan 31 15:25:58 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQ5Tj07dNz58k0X; Wed, 31 Jan 2024 15:26:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQ5Th6ch8z45Nv; Wed, 31 Jan 2024 15:26:00 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706714760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rSx2df62gKiV4EMf+drBtFGCP81w6PHZKdDIhbIHKXQ=; b=RExO/AXj2KbATPrzZ8dZrFP9ozobj6sid5vd9Bl0VlbD3I50AYrzXGGaw/eYpjHi4wsAUU dDa7zcmxUXrmjp7VEbkgFQjrl+un05N08CIGb1CodCKUddXECUw74ZU3LrcgJQKhF1roc0 DXh6e3SS+0OxmZ2xSmADRlgYqJdJT2nA9K7gazZCvDBk6SAQFKC0FfMVx2n4+3YT85C7Lq QNjsA0XVsfIa3l0fI3gV8E5quy8G+/tjr8p71X2L5Qd8Q8iKLFVuZihSOX5b05CW5nHnEy NzNytWvluyQDF52W8vlkU5yt40N++sMT6W82wSedB30xwkD88tly94u5fHtuzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706714760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rSx2df62gKiV4EMf+drBtFGCP81w6PHZKdDIhbIHKXQ=; b=s3qLik4jNxxuY+BjksP8axVrn//cCyGqU8gHBJjcRaCBqd6RBnkj0H5bBgYsZEkjb94SrJ +LUkVa0n/IkVrptEL4Z4f8aRYiKCC+OR/iKYvR6iLHWDi3pqBM1/Ikl/Slzfsdy1j+QyO0 M1rMNW/a3RUQP78o1pUQPL8E1MTU5eG/UjiK3W5x01BEztUeCWNjctGyUQxkeFl55/uytI Pj0l9uQtgVbKNFpHHG5jcQYsPVi9+CqleDg9WPv8qcsmbxCPIrv3XNs9myYLsmt7cFLv9A H5cB9HpmjMI5ycR/tp7vw0YJWC3f9PHEtDLgiQMgngukBM44Ttb70QMbVplHtg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706714760; a=rsa-sha256; cv=none; b=WKe9l2jp0GKvCpSKNmoDeZrOK+2SpORfD+oiZrWVB6I//oGPkDGWG+J0qNOhN2+O7mmZ71 XbAWq+UQY1w69lfFHIPmaf0W6SIZzJ13zWCAd3FWzziR6floqiPDmoA+Y0n9in6geJkpOo B20gGZHT62p8vIfN742LKNH0n6yCjcBW/vhFdqycdklghpqw68D7T1BLCNQSNmfziNTsSk +d72558B30r3ysXaFXvPylUXOQxJtQLMrnpwamGddqq2YuHoOQfwLiZfdtWt0Ef/YVNBNz RoA5pqoXltoUdZhkWgoK+U01amqKhuPQ4demwBnfBbLbcf6yGnVcpDPeCGSeZQ== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id AEB5C1D2D6; Wed, 31 Jan 2024 15:26:00 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 18EBD5F89; Wed, 31 Jan 2024 07:26:00 -0800 (PST) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id WTdV8kJYKEh0; Wed, 31 Jan 2024 07:25:58 -0800 (PST) Message-ID: DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 57D0B5F82 Date: Wed, 31 Jan 2024 07:25:58 -0800 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 9f0ce98efea9 - main - irc/rbot: Moved man to share/man Content-Language: en-US From: Bryan Drewery To: Moin Rahman Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202401291954.40TJsWBe042649@gitrepo.freebsd.org> <06e37dcd52f33a4fda060d86048e629f@FreeBSD.org> <7b83c2c7-5048-409c-a55f-666c10086d71@FreeBSD.org> Organization: FreeBSD In-Reply-To: <7b83c2c7-5048-409c-a55f-666c10086d71@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/31/2024 7:23 AM, Bryan Drewery wrote: > On 1/31/2024 7:09 AM, Moin Rahman wrote: >> >> >>> On Jan 31, 2024, at 3:51 PM, Bryan Drewery wrote: >>> >>> On 2024-01-29 11:54, Muhammad Moinur Rahman wrote: >>>> The branch main has been updated by bofh: >>>> URL: >>>> https://cgit.FreeBSD.org/ports/commit/?id=9f0ce98efea9ca39d4930569c7a072a9431793b2 >>>> commit 9f0ce98efea9ca39d4930569c7a072a9431793b2 >>>> Author:     Muhammad Moinur Rahman >>>> AuthorDate: 2024-01-29 18:03:32 +0000 >>>> Commit:     Muhammad Moinur Rahman >>>> CommitDate: 2024-01-29 19:54:13 +0000 >>>>     irc/rbot: Moved man to share/man >>> >>> I think you should be testing these before committing. This one >>> doesn't use GNU configure. >> What makes you think that my commits are not well tested? >> This was when I committed: >> https://pkg.bofh.network/data/132-default/2024-01-29_19h19m37s/logs/rbot-20160325_2,1.log >> >> This is now: >> https://pkg.bofh.network/data/132-default/2024-01-31_16h01m20s/logs/rbot-20160325_2,1.log >> >> GNU_CONFIGURE_MANPREFIX has nothing to do with GNU_CONFIGURE itself >> and it is mainly passed >> as a var to CONFIGURE_ARGS. > > GNU_CONFIGURE_MANPREFIX absolutely only has to do with GNU_CONFIGURE. > Check bsd.port.mk. > > ~/git/ports/main/irc/rbot # make -V CONFIGURE_ARGS > --prefix=/usr/local > ~/git/ports/main/irc/rbot # make -V __LATE_CONFIGURE_ARGS > > > __LATE_CONFIGURE_ARGS only includes GNU_CONFIGURE_MANPREFIX if > `./configure --help` shows a mandir. > > > Do you have output in either of those? or CONFIGURE_CMD? ~/git/ports/main/irc/rbot # make -V CONFIGURE_CMD ./configure The only way it could work for you is if that says "ruby setup.rb" which doesn't make sense since ruby.mk does not set that, it uses ruby-setup-configure target. This is required to build for me: diff --git irc/rbot/Makefile irc/rbot/Makefile index 06984ff5bcfc..0d9304566079 100644 --- irc/rbot/Makefile +++ irc/rbot/Makefile @@ -25,8 +25,7 @@ LIB_DEPENDS= libtokyocabinet.so:databases/tokyocabinet USES= cpe ruby:setup -GNU_CONFIGURE_MANPREFIX= ${PREFIX}/share -CONFIGURE_ARGS= --prefix=${PREFIX} +CONFIGURE_ARGS= --prefix=${PREFIX} --mandir=${PREFIX}/share/man NO_ARCH= yes USE_GITHUB= yes > > >> >>> ===>   Building rbot-20160325_2,1 >>> pkg-static: Unable to access file >>> /wrkdirs/usr/ports/irc/rbot/work/stage/usr/local/share/man/rbot.xml.gz:No such file or directory >>> *** Error code 1 >> This is not reproducible in latest ports tree at least. >> >>> >>>>     Approved by:    portmgr (blanket) >>>> --- >>>> irc/rbot/Makefile  | 3 ++- >>>> irc/rbot/pkg-plist | 2 +- >>>> 2 files changed, 3 insertions(+), 2 deletions(-) >>>> diff --git a/irc/rbot/Makefile b/irc/rbot/Makefile >>>> index aca35f99db58..06984ff5bcfc 100644 >>>> --- a/irc/rbot/Makefile >>>> +++ b/irc/rbot/Makefile >>>> @@ -1,6 +1,6 @@ >>>> PORTNAME= rbot >>>> PORTVERSION= 20160325 >>>> -PORTREVISION= 1 >>>> +PORTREVISION= 2 >>>> PORTEPOCH= 1 >>>> CATEGORIES= irc ruby >>>> @@ -25,6 +25,7 @@ LIB_DEPENDS= >>>> libtokyocabinet.so:databases/tokyocabinet >>>> USES= cpe ruby:setup >>>> +GNU_CONFIGURE_MANPREFIX= ${PREFIX}/share >>>> CONFIGURE_ARGS= --prefix=${PREFIX} >>>> NO_ARCH= yes >>>> diff --git a/irc/rbot/pkg-plist b/irc/rbot/pkg-plist >>>> index e411686f8392..dfe970ca87da 100644 >>>> --- a/irc/rbot/pkg-plist >>>> +++ b/irc/rbot/pkg-plist >>>> @@ -42,7 +42,7 @@ bin/rbotdb >>>> %%RUBY_SITELIBDIR%%/rbot/registry/tc.rb >>>> %%RUBY_SITELIBDIR%%/rbot/rfc2812.rb >>>> %%RUBY_SITELIBDIR%%/rbot/timer.rb >>>> -man/rbot.xml.gz >>>> +share/man/rbot.xml.gz >>>> %%DATADIR%%/contrib/plugins/stats.rb >>>> %%DATADIR%%/contrib/plugins/vandale.rb >>>> %%DATADIR%%/filters/rss.rb >> > -- Bryan Drewery