From owner-freebsd-threads@FreeBSD.ORG  Thu Jan 24 22:35:30 2008
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E0D8416A417;
	Thu, 24 Jan 2008 22:35:30 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id CC17013C469;
	Thu, 24 Jan 2008 22:35:30 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 635F21A4D83; Thu, 24 Jan 2008 14:31:33 -0800 (PST)
Date: Thu, 24 Jan 2008 14:31:33 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Daniel Eischen <deischen@freebsd.org>
Message-ID: <20080124223133.GU99258@elvis.mu.org>
References: <200801240850.m0O8o2JQ023500@freefall.freebsd.org>
	<4798564B.7070500@elischer.org>
	<20080124222339.GT99258@elvis.mu.org>
	<Pine.GSO.4.64.0801241732070.16957@sea.ntplx.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.GSO.4.64.0801241732070.16957@sea.ntplx.net>
User-Agent: Mutt/1.4.2.3i
Cc: Gary Stanley <gary@velocity-servers.net>,
	Julian Elischer <julian@elischer.org>, freebsd-threads@freebsd.org
Subject: Re: threads/119920: fork broken in libpthread
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jan 2008 22:35:31 -0000

* Daniel Eischen <deischen@freebsd.org> [080124 14:28] wrote:
> On Thu, 24 Jan 2008, Alfred Perlstein wrote:
> 
> >* Julian Elischer <julian@elischer.org> [080124 01:17] wrote:
> >>Gary Stanley wrote:
> >>>The following reply was made to PR threads/119920; it has been noted by
> >>>GNATS.
> >>>
> >>>From: Gary Stanley <gary@velocity-servers.net>
> >>>To: bug-followup@FreeBSD.org
> >>>Cc:
> >>>Subject: Re: threads/119920: fork broken in libpthread
> >>>Date: Thu, 24 Jan 2008 03:24:47 -0500
> >>>
> >>>I also have this problem, see threads/118715
> >>>
> >>>I was able to grab some ktrace info, but most of the time the process
> >>>is stuck, and ktrace doesn't display any data.
> >>>
> >>>_______________________________________________
> >>>freebsd-threads@freebsd.org mailing list
> >>>http://lists.freebsd.org/mailman/listinfo/freebsd-threads
> >>>To unsubscribe, send any mail to 
> >>>"freebsd-threads-unsubscribe@freebsd.org"
> >>
> >>dan what IS the fix for this?  I assume you must have fixed it in
> >>-current/7
> >>
> >>what was YOUR fix alfred?
> >
> >Attached.
> 
> Which isn't a correct fix, BTW.  It is possible that the unlock
> can try to give the lock to a non-existent thread.

Yes, I understand that problem, but it's not clear to my why/how it can happen.

I guess because another thread could put itself on the "blocked queue"
for that lock?  Is there a way to prevent that or to clear the lock
afterward?

-Alfred