From owner-svn-src-all@freebsd.org Sun Dec 18 16:49:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1FE1C87952; Sun, 18 Dec 2016 16:49:22 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA439910; Sun, 18 Dec 2016 16:49:22 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::584d:b4f3:ff81:8b6c] (unknown [IPv6:2001:7b8:3a7:0:584d:b4f3:ff81:8b6c]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id A97D53F4D3; Sun, 18 Dec 2016 17:49:19 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_9BFE0C23-B76B-4587-880F-2EE1087660E7"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r310232 - head/sys/dev/mlx4/mlx4_ib From: Dimitry Andric In-Reply-To: Date: Sun, 18 Dec 2016 17:49:07 +0100 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201612181521.uBIFLcB3030383@repo.freebsd.org> To: Ed Schouten X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2016 16:49:23 -0000 --Apple-Mail=_9BFE0C23-B76B-4587-880F-2EE1087660E7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 18 Dec 2016, at 17:37, Ed Schouten wrote: >=20 > 2016-12-18 16:21 GMT+01:00 Dimitry Andric : >> Modified: head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:10:08 = 2016 (r310231) >> +++ head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:21:38 = 2016 (r310232) >> @@ -79,7 +79,7 @@ static ssize_t store_admin_alias_guid(st >> container_of(attr, struct mlx4_ib_iov_sysfs_attr, = dentry); >> struct mlx4_ib_iov_port *port =3D mlx4_ib_iov_dentry->ctx; >> struct mlx4_ib_dev *mdev =3D port->dev; >> - u64 sysadmin_ag_val; >> + unsigned long long sysadmin_ag_val; >>=20 >> record_num =3D mlx4_ib_iov_dentry->entry_num / 8; >> guid_index_in_rec =3D mlx4_ib_iov_dentry->entry_num % 8; >=20 > Looking at the code, the intent is that an actual 64-bit integer is > parsed; not an unsigned long long. What's wrong with using > inttypes.h's SCNx64? That is how I originally submitted it in the review, though with , as it is most often used in kernel sources. However, see Hans's comment in the review here: https://reviews.freebsd.org/D8831#182872 I don't mind either way. -Dimitry --Apple-Mail=_9BFE0C23-B76B-4587-880F-2EE1087660E7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhWvg8ACgkQsF6jCi4glqNdGACgqVHhTleeOATnuSWQbK+kIaE0 ti8AoJhwK0REdVCFsAEzsQ1v+GFsWJ5z =WPK8 -----END PGP SIGNATURE----- --Apple-Mail=_9BFE0C23-B76B-4587-880F-2EE1087660E7--