Date: Sun, 12 Nov 2023 11:02:18 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274953] emulators/wine-devel: Makefile maintenance & dependency cleanup Message-ID: <bug-274953-7788-x7jetP7EGq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-274953-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-274953-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274953 Gerald Pfeifer <gerald@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gerald@FreeBSD.org --- Comment #2 from Gerald Pfeifer <gerald@FreeBSD.org> --- At a first glance this looks fine. Just please, *please*, PLEASE let's not go for all those whitespace changes. Damjan made a series of such whitespace changes when becoming maintainer two years ago. This now would be yet another such set of changes. * That makes the wine-devel and wine ports diverge for no real benefit (and I worked to align them again after Damjan's changes). * It destroys `git blame`. * And many of us really don't consider the PLIST_SUB change, let alone (cd ${WRKSRC} && \ ${MAKE_CMD} depend) over cd ${WRKSRC} && ${MAKE_CMD} depend and improvement (looking at ports in general). (Don't get me wrong, I also have been trying to stay within 80 columns; it's just a balance.) This port has been portlint-clean (where reasonable) for two decades. portclippy and portfmt have their own preferences - and I recommend against simply applying the latter. If you want to apply changes suggested by the former, I'd do that as a distinct commit. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-274953-7788-x7jetP7EGq>