From owner-freebsd-fs@freebsd.org Sat Nov 5 01:42:38 2016 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB2ADC2FAC4 for ; Sat, 5 Nov 2016 01:42:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CAAD2DF0 for ; Sat, 5 Nov 2016 01:42:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uA51gcD1064763 for ; Sat, 5 Nov 2016 01:42:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 176449] zfs(1): ZFS NFS export went wrong with special hostname character Date: Sat, 05 Nov 2016 01:42:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 9.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: eborisch+FreeBSD@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2016 01:42:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D176449 --- Comment #8 from eborisch+FreeBSD@gmail.com --- (In reply to Martin Birgmeier from comment #7) The current behavior strips leading dashes from un-recognized options. Input =3D -foo -ro mapall test_host test-host current output =3D foo -ro -mapall test_host test host w/patch in bug #168158 =3D foo -ro -mapall test_host test-host w/patch in bug #176449 =3D -foo -ro -mapall test_host test-host So the other patch is minimal change (only fixes preserving dashes inside h= ost names) while the patch here also passes unrecognized options with leading dashes. Not sure which is preferred in this case; stripping the dash is likely not optimal from a security point of view, as -foo becomes the hostname foo... Should it perhaps remove strings that look like options but aren't recogniz= ed? Or pass them as (invalid) arguments into exports? --=20 You are receiving this mail because: You are the assignee for the bug.=