Date: Sat, 05 Nov 2016 01:42:38 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 176449] zfs(1): ZFS NFS export went wrong with special hostname character Message-ID: <bug-176449-3630-70mC1Tn2F8@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-176449-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-176449-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D176449 --- Comment #8 from eborisch+FreeBSD@gmail.com --- (In reply to Martin Birgmeier from comment #7) The current behavior strips leading dashes from un-recognized options. Input =3D -foo -ro mapall test_host test-host current output =3D foo -ro -mapall test_host test host w/patch in bug #168158 =3D foo -ro -mapall test_host test-host w/patch in bug #176449 =3D -foo -ro -mapall test_host test-host So the other patch is minimal change (only fixes preserving dashes inside h= ost names) while the patch here also passes unrecognized options with leading dashes. Not sure which is preferred in this case; stripping the dash is likely not optimal from a security point of view, as -foo becomes the hostname foo... Should it perhaps remove strings that look like options but aren't recogniz= ed? Or pass them as (invalid) arguments into exports? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-176449-3630-70mC1Tn2F8>