From owner-svn-src-all@FreeBSD.ORG Mon Aug 19 17:37:41 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id BF17D7F7; Mon, 19 Aug 2013 17:37:41 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pb0-x230.google.com (mail-pb0-x230.google.com [IPv6:2607:f8b0:400e:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 86BB22D01; Mon, 19 Aug 2013 17:37:41 +0000 (UTC) Received: by mail-pb0-f48.google.com with SMTP id ma3so5206793pbc.21 for ; Mon, 19 Aug 2013 10:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=EwU1E7rKPB581mQyuiimB4kvArzxRtNXrK72mgnjJDs=; b=JO11yV0ptfFscJLnPCYNgafjljI5p0Q91v/0vSSoh2xzcg8zOVeGW7FL7aXNzHDO6s +YUqUd3ZZHhsi1gj8ofTGNsELiCji6D5FK+irwb9JLmJlVQumQgYq3hwF7lDUcRkSzM9 SAnePzZwbPRl+azKp1whGpjBgwwJZ2zkv/N5cyJKuvEenvKPYRWNLpTNQEAKCRsyKSp4 NOco4osik6kHWlqvmQh1njVh2Y1XCONrFGkr0jbHzui7MjTOwQTr/sj8UGs32W3skVsL eEue/VQYIWSBFnm9KbsvVhe6PlO9hTlNQQX7+/oggjYMbKpIwsSFCQH4jgDWeUm9n8+v M9Qw== X-Received: by 10.68.13.132 with SMTP id h4mr14420201pbc.99.1376933861235; Mon, 19 Aug 2013 10:37:41 -0700 (PDT) Received: from [10.192.166.0] (stargate.chelsio.com. [67.207.112.58]) by mx.google.com with ESMTPSA id om2sm16328739pbc.30.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 19 Aug 2013 10:37:40 -0700 (PDT) Sender: Navdeep Parhar Message-ID: <521257E2.4020502@FreeBSD.org> Date: Mon, 19 Aug 2013 10:37:38 -0700 From: Navdeep Parhar User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130819 Thunderbird/17.0.8 MIME-Version: 1.0 To: Andre Oppermann Subject: Re: svn commit: r254524 - head/sys/sys References: <201308191356.r7JDuELE075073@svn.freebsd.org> In-Reply-To: <201308191356.r7JDuELE075073@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Aug 2013 17:37:41 -0000 On 08/19/13 06:56, Andre Oppermann wrote: > Author: andre > Date: Mon Aug 19 13:56:14 2013 > New Revision: 254524 > URL: http://svnweb.freebsd.org/changeset/base/254524 > > Log: > Add four additional M_PROTOFLAGS[9-12] for protocol specific use. > > Discussed with: trociny, glebius, adrian > > Modified: > head/sys/sys/mbuf.h > > Modified: head/sys/sys/mbuf.h > ============================================================================== > --- head/sys/sys/mbuf.h Mon Aug 19 13:27:32 2013 (r254523) > +++ head/sys/sys/mbuf.h Mon Aug 19 13:56:14 2013 (r254524) > @@ -196,22 +196,24 @@ struct mbuf { > #define M_FRAG 0x00000800 /* packet is a fragment of a larger packet */ > #define M_FIRSTFRAG 0x00001000 /* packet is first fragment */ > #define M_LASTFRAG 0x00002000 /* packet is last fragment */ > - /* 0x00004000 free */ > - /* 0x00008000 free */ > +#define M_PROTO9 0x00004000 /* protocol-specific */ > +#define M_PROTO10 0x00008000 /* protocol-specific */ > #define M_VLANTAG 0x00010000 /* ether_vtag is valid */ > #define M_PROMISC 0x00020000 /* packet was not for us */ > - /* 0x00040000 free */ > +#define M_PROTO11 0x00040000 /* protocol-specific */ > #define M_PROTO6 0x00080000 /* protocol-specific */ > #define M_PROTO7 0x00100000 /* protocol-specific */ > #define M_PROTO8 0x00200000 /* protocol-specific */ > #define M_FLOWID 0x00400000 /* deprecated: flowid is valid */ > +#define M_PROTO12 0x00800000 /* protocol-specific */ > #define M_HASHTYPEBITS 0x0F000000 /* mask of bits holding flowid hash type */ Why reuse the freed up bits so soon (at least one of which I think was prematurely GC'ed -- see my other email on M_NOFREE). There was room beyond M_HASHTYPEBITS, no? Regards, Navdeep