From owner-svn-src-projects@FreeBSD.ORG  Wed Oct  3 23:24:47 2012
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 07EC01065677;
	Wed,  3 Oct 2012 23:24:47 +0000 (UTC)
	(envelope-from grehan@freebsd.org)
Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12])
	by mx1.freebsd.org (Postfix) with ESMTP id B0A5D8FC0C;
	Wed,  3 Oct 2012 23:24:46 +0000 (UTC)
Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57])
	by alto.onthenet.com.au (Postfix) with ESMTPS id F31E3139AE;
	Thu,  4 Oct 2012 09:24:44 +1000 (EST)
Received: from Peter-Grehans-MacBook-Pro.local
	(c-75-70-8-22.hsd1.co.comcast.net [75.70.8.22])
	by dommail.onthenet.com.au (MOS 4.2.4-GA)
	with ESMTP id BGU29011 (AUTH peterg@ptree32.com.au);
	Thu, 4 Oct 2012 09:24:42 +1000
Message-ID: <506CC937.2010409@freebsd.org>
Date: Wed, 03 Oct 2012 17:24:39 -0600
From: Peter Grehan <grehan@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
	rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20
MIME-Version: 1.0
To: Peter Jeremy <peter@rulingia.com>
References: <201210030422.q934Mdt0060521@svn.freebsd.org>
	<20121003225011.GA61464@vps.rulingia.com>
In-Reply-To: <20121003225011.GA61464@vps.rulingia.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Junkmail-Info: RCVD_IN_PBL,RCVD_IN_SORBS_DUL,RDNS_DYNAMIC,SPF_SOFTFAIL
X-Junkmail-Status: score=29/51, host=dommail.onthenet.com.au
Cc: svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: svn commit: r241153 - in projects/bhyve/sys/boot: common
	userboot/userboot
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2012 23:24:47 -0000

Hi Peter,

> IMHO, the comment here is somewhat confusing

  Agreed.

> Can I suggest an alternate comment along the lines of:
> /*
>   * (Maximum?) Dictionary size in cells.  Note that the default FICL dictionary
>   * requires ~4000 cells.
>   */

  The irony is that FICL_DEFAULT_DICT, used if the passed in param to 
ficlInitSystem() is <=0, is actually 12288 on all arches.

  How about if I just remove the '~4000 cells' text, and maybe put in 
something like

  * FreeBSD loader default dictionary cells

  The irony is that FICL_DEFAULT_DICT, used if the passed in param to 
ficlInitSystem() is <=0, is actually 12288 on all arches.

later,

Peter.