From owner-freebsd-ports@FreeBSD.ORG Fri Jul 17 19:30:31 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9258A10656F5 for ; Fri, 17 Jul 2009 19:30:31 +0000 (UTC) (envelope-from nox@jelal.kn-bremen.de) Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116]) by mx1.freebsd.org (Postfix) with ESMTP id 1FAB88FC08 for ; Fri, 17 Jul 2009 19:30:30 +0000 (UTC) (envelope-from nox@jelal.kn-bremen.de) Received: by smtp.kn-bremen.de (Postfix, from userid 10) id 7B9C71E002C0; Fri, 17 Jul 2009 21:30:29 +0200 (CEST) Received: from triton.kn-bremen.de (noident@localhost [127.0.0.1]) by triton.kn-bremen.de (8.14.3/8.14.3) with ESMTP id n6HJPxP1060059; Fri, 17 Jul 2009 21:25:59 +0200 (CEST) (envelope-from nox@triton.kn-bremen.de) Received: (from nox@localhost) by triton.kn-bremen.de (8.14.3/8.14.3/Submit) id n6HJPxSQ060058; Fri, 17 Jul 2009 21:25:59 +0200 (CEST) (envelope-from nox) From: Juergen Lock Date: Fri, 17 Jul 2009 21:25:59 +0200 To: Juergen Lock Message-ID: <20090717192559.GA59717@triton.kn-bremen.de> References: <20090704112402.GA87051@triton.kn-bremen.de> <20090704120713.GA17665@triton.kn-bremen.de> <20090706164652.GA38440@triton.kn-bremen.de> <20090707214134.GA66882@triton.kn-bremen.de> <20090709184446.GA20846@hades.panopticon> <20090710220705.GA43250@triton.kn-bremen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090710220705.GA43250@triton.kn-bremen.de> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Chris Petrik , Dmitry Marakasov , freebsd-ports@FreeBSD.org Subject: Re: call for testing: print/hplip update, pass 2 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2009 19:30:32 -0000 On Sat, Jul 11, 2009 at 12:07:05AM +0200, Juergen Lock wrote: > On Thu, Jul 09, 2009 at 10:44:46PM +0400, Dmitry Marakasov wrote: > > * Juergen Lock (nox@jelal.kn-bremen.de) wrote: > > > > > I got a new printer today (the old one's scanner died... ): and now hplip > > > has usb issues with that one: > > > > > > hp-systray reports on startup: (and also on refresh) > > > > Thanks for testing, Jurgen! I've merged your changes into the port > > and polished it a bit, so now it builds on all FreeBSD versions and > > without plist problems. > > > > Unfortunately I'm unable to test this and I have very shallow vision > > of functionality and regressions of this update. > > > > First of all, here's latest version of the port: > > http://people.freebsd.org/~amdmi3/hplip.shar > > Please use it as a base for further changes (and also please check > > that I haven't missed any of your enchantments). > > > This got lost: > > Index: Makefile > @@ -84,7 +84,12 @@ > ${WRKSRC}/ui4/devmgr5.py > @${REINPLACE_CMD} -e 's|/etc/dbus-1/system.d|${LOCALBASE}/etc/dbus-1/system.d|g ; \ > s|/usr/share/dbus-1/system-services|${LOCALBASE}/share/dbus-1/system-services|g' \ > - ${WRKSRC}/Makefile.am ${WRKSRC}/Makefile.in > + ${WRKSRC}/Makefile.am ${WRKSRC}/Makefile.in \ > + ${WRKSRC}/check.py ${WRKSRC}/hpssd.py \ > + ${WRKSRC}/base/g.py ${WRKSRC}/fax/backend/hpfax.py \ > + ${WRKSRC}/installer/distros.dat \ > + ${WRKSRC}/installer/core_install.py \ > + ${WRKSRC}/prnt/hpijs/ljzjs.cpp > @${REINPLACE_CMD} 's|/etc/xdg|${PREFIX}&|g' \ > ${WRKSRC}/configure ${WRKSRC}/configure.in > @${REINPLACE_CMD} 's|-lpthread|${PTHREAD_LIBS}|g' \ > > > As I understood, the update has regressions compared to the hplip > > version which is currently in ports, thus it's not possible to just > > update it. Can you (both Jurgen and Chris) give me a brief summary of > > how the update is better and worse than the current version? If it has > > enough working/new features, it would be nice to commit this change as > > hplip-devel. And, in either case, how hard is it (if possible) to > > fix the regressions? > > Well the usb issue with my new printer also exists with the old version > thats currently in ports as I now found out, and the only other issue > that I remember (printing ascii or ps to the fax queue) could just as > well be a problem/incompatiblity with the new cups version... And > additionally, the old version's hp-setup seems to be incompatible with > today's cups, at least it was unable to add the network print queues > for my new printer when I tried it now. (unlike the new version. And > also the gui certainly has improved.) > > Btw that testing just unconvered another bug: the package needs to add > hpaio to ${LOCALBASE)/etc/sane.d/dll.conf too... > > I guess I should test the fax queue on Linux, and possibly usb on head... > (fixing usb would at least need someone that still knows the old usb > stack I'd say. _If_ it works on head. :) Alright, I just looked at this again and got usb back to working here (7-stable/amd64) with the following simple patch: Index: io/hpmud/musb.c @@ -122,7 +122,7 @@ static int get_string_descriptor(usb_dev { ret = usb_control_msg(dev, USB_ENDPOINT_IN, USB_REQ_GET_DESCRIPTOR, (USB_DT_STRING << 8) + index, 0x409, tbuf, sizeof(tbuf), LIBUSB_CONTROL_REQ_TIMEOUT); - if (ret==0) + if (ret==0 || ret == -EIO) { /* This retry is necessary for lj1000 and lj1005. des 12/12/07 Also HP Photosmart 42xx seems to suffer transient errors with serial id */ My guess is other usb stacks return 0 here where ours returns -EIO... (or at least or old one does, still haven't tested this on 8.0 because head has ata issues on this box, see http://docs.freebsd.org/cgi/mid.cgi?20090628101656.GA38983 and http://lists.freebsd.org/pipermail/freebsd-current/2009-July/009013.html .) HTH, Juergen