From nobody Sat Sep 13 12:26:12 2025 X-Original-To: java@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cP9Wf3QRPz62h9b for ; Sat, 13 Sep 2025 12:26:22 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp-relay-int-backup.realworks.nl (smtp-relay-int-backup.realworks.nl [87.255.56.188]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cP9Wc6j2qz3Fks for ; Sat, 13 Sep 2025 12:26:20 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=klop.ws header.s=rw2 header.b=MFg7qqjn; dmarc=pass (policy=quarantine) header.from=klop.ws; spf=pass (mx1.freebsd.org: domain of ronald-lists@klop.ws designates 87.255.56.188 as permitted sender) smtp.mailfrom=ronald-lists@klop.ws Received: from smtp-relay-int-backup.realworks.nl (crmpreview7.colo2.realworks.nl [10.2.52.37]) by mailrelayint2.colo2.realworks.nl (Postfix) with ESMTP id 4cP9WS4tsFz1G6; Sat, 13 Sep 2025 14:26:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klop.ws; s=rw2; t=1757766372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JeSsYaC0RHYNCMzomAR1HlZjWMcUi9dR5TYFA6C7iW4=; b=MFg7qqjneV2tv4m0Xgs0WontOxWnflobp5vrOXldIlLY96FEG8fLgdSFBrMlnNV2wZzWN9 WRhC5PrSCVtXTPs/C2Lf+4k77TwKLx1rQWi+GIcypFYikkyDUaMzRDGDsnVlT1zI6K0N/W 6xp4/8GVcgWvFL6X5jN3x4ebrP/A2aRTNxpgQqlfBgprbwALhRnlT237LuEm5k/Hdcqf6n 2EOQYTWyNhKjbGTI0CLQC5dSwoYbMY1oKV1JUPMR0EAv/7t4Go+UG5eu9q4vANihmQMBFn EtUfuPZsz4qKshXfFhzRJDL911q79kqZbwSP3/pwtAzsI0qwzmYNzh9woaxVuw== Received: from crmpreview7.colo2.realworks.nl (localhost [127.0.0.1]) by crmpreview7.colo2.realworks.nl (Postfix) with ESMTP id 8212F180084; Sat, 13 Sep 2025 14:26:12 +0200 (CEST) Date: Sat, 13 Sep 2025 14:26:12 +0200 (CEST) From: Ronald Klop To: Harald Eilertsen , java@freebsd.org Message-ID: <699985539.12442.1757766372478@localhost> In-Reply-To: <246244335.3613.1757582776002@localhost> References: <1221594030.658.1756976173189@localhost> <1330428831.1750.1756980558066@localhost> <2053927433.1876.1757575928041@localhost> <246244335.3613.1757582776002@localhost> Subject: Re: openjdk build failures on "nm" List-Id: Porting Java to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-java List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-java@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_12441_226741785.1757766372128" X-Mailer: Realworks (765.87) X-Originating-Host: from (83-81-212-149.cable.dynamic.v4.ziggo.nl [83.81.212.149]) by crmpreview7.colo2.realworks.nl [10.2.52.37] with HTTP; Sat, 13 Sep 2025 14:26:12 +0200 Importance: Normal X-Priority: 3 (Normal) X-Originating-User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:142.0) Gecko/20100101 Firefox/142.0 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[klop.ws,quarantine]; R_DKIM_ALLOW(-0.20)[klop.ws:s=rw2]; R_SPF_ALLOW(-0.20)[+ip4:87.255.56.128/26]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ASN(0.00)[asn:38930, ipnet:87.255.32.0/19, country:NL]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; HAS_X_PRIO_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; MLMMJ_DEST(0.00)[java@freebsd.org]; DKIM_TRACE(0.00)[klop.ws:+] X-Rspamd-Queue-Id: 4cP9Wc6j2qz3Fks ------=_Part_12441_226741785.1757766372128 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Ok. Change didn't work. Did learn a bit more. The openjdk build totally ignores MAKE_JOBS_UNSAFE and MAKE_JOBS_NUMBER. :-) See: https://pkg-status.freebsd.org/beefy16/data/135amd64-default/56c5cbbc8d99/logs/openjdk17-17.0.16+8.1_1.log checking for number of cores... 28 checking for memory size... 130926 MB checking for appropriate number of jobs to run in parallel... 28 The configure script detects cores and memory and calculates itself how many jobs it uses. I now added these lines to the openjdk17/Makefile and tested in my poudriere that this makes the build take these variables into account. +.if defined(MAKE_JOBS_UNSAFE) +CONFIGURE_ARGS+= --with-jobs=1 +.elif defined(MAKE_JOBS_NUMBER) +CONFIGURE_ARGS+= --with-jobs=${MAKE_JOBS_NUMBER} +.endif Any objections or is everybody happy if I add this? Regards, Ronald. Van: Ronald Klop Datum: donderdag, 11 september 2025 11:26 Aan: Harald Eilertsen CC: java@freebsd.org Onderwerp: Re: openjdk build failures on "nm" > > I committed the change. > > Looking through https://portsfallout.com/fallout?port=java/openjdk again, I noticed that it does not fail on main, only on 13.5 and 14.2. I don't know if that is a coincidence, a difference in the pkg cluster on main or some difference in clang/llvm or other build tooling. > > But I thought it is worth mentioning. > > Regards, > Ronald. > > > Van: Harald Eilertsen > Datum: donderdag, 11 september 2025 10:15 > Aan: Ronald Klop > CC: java@freebsd.org > Onderwerp: Re: openjdk build failures on "nm" >> >> On Thu, Sep 11, 2025 at 09:32:08AM +0200, Ronald Klop wrote: >> > As it seems hard to debug, what do the java@ maintainers think of this experiment? >> > >> > diff --git a/java/openjdk17/Makefile b/java/openjdk17/Makefile >> > index 5cb25e6aee72..ba7001ff2bd0 100644 >> > --- a/java/openjdk17/Makefile >> > +++ b/java/openjdk17/Makefile >> > @@ -38,7 +38,7 @@ GH_PROJECT= jdk17u >> > >> > NO_CCACHE= yes >> > >> > -_MAKE_JOBS= # >> > +MAKE_JOBS_UNSAFE= yes >> > MAKE_ENV= LANG="C" \ >> > LC_ALL="C" \ >> > CLASSPATH="" \ >> >> That's well spotted! I think this is definitely worth trying. I'm no >> expert on the ports Makefiles myself, but was told to use >> MAKE_JOBS_UNSAFE instead in the review for openjdk24. Haven't gone >> through all the ancient version yet, as my focus is mainly on mainline, >> and these days on openjdk25. >> >> > I can commit this today to openjdk17 and if builds start to succeed to other openjdk* ports. >> >> I'm in favour! >> >> H! >> >> >> > > ------=_Part_12441_226741785.1757766372128 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit Ok.

Change didn't work. Did learn a bit more.

The openjdk build totally ignores MAKE_JOBS_UNSAFE and MAKE_JOBS_NUMBER. :-)
See:
https://pkg-status.freebsd.org/beefy16/data/135amd64-default/56c5cbbc8d99/logs/openjdk17-17.0.16+8.1_1.log 
checking for number of cores... 28
checking for memory size... 130926 MB
checking for appropriate number of jobs to run in parallel... 28

The configure script detects cores and memory and calculates itself how many jobs it uses.

I now added these lines to the openjdk17/Makefile and tested in my poudriere that this makes the build take these variables into account. 
+.if defined(MAKE_JOBS_UNSAFE)
+CONFIGURE_ARGS+=       --with-jobs=1
+.elif defined(MAKE_JOBS_NUMBER)
+CONFIGURE_ARGS+=       --with-jobs=${MAKE_JOBS_NUMBER}
+.endif

Any objections or is everybody happy if I add this?

Regards,
Ronald.


 

Van: Ronald Klop <ronald-lists@klop.ws>
Datum: donderdag, 11 september 2025 11:26
Aan: Harald Eilertsen <haraldei@anduin.net>
CC: java@freebsd.org
Onderwerp: Re: openjdk build failures on "nm"

I committed the change.

Looking through https://portsfallout.com/fallout?port=java/openjdk again, I noticed that it does not fail on main, only on 13.5 and 14.2. I don't know if that is a coincidence, a difference in the pkg cluster on main or some difference in clang/llvm or other build tooling.

But I thought it is worth mentioning.

Regards,
Ronald.

 

Van: Harald Eilertsen <haraldei@anduin.net>
Datum: donderdag, 11 september 2025 10:15
Aan: Ronald Klop <ronald-lists@klop.ws>
CC: java@freebsd.org
Onderwerp: Re: openjdk build failures on "nm"

On Thu, Sep 11, 2025 at 09:32:08AM +0200, Ronald Klop wrote:
> As it seems hard to debug, what do the java@ maintainers think of this experiment?
>
> diff --git a/java/openjdk17/Makefile b/java/openjdk17/Makefile
> index 5cb25e6aee72..ba7001ff2bd0 100644
> --- a/java/openjdk17/Makefile
> +++ b/java/openjdk17/Makefile
> @@ -38,7 +38,7 @@ GH_PROJECT=   jdk17u
>
> NO_CCACHE=     yes
>
> -_MAKE_JOBS=    #
> +MAKE_JOBS_UNSAFE=      yes
> MAKE_ENV=      LANG="C" \
>                LC_ALL="C" \
>                CLASSPATH="" \

That's well spotted! I think this is definitely worth trying. I'm no
expert on the ports Makefiles myself, but was told to use
MAKE_JOBS_UNSAFE instead in the review for openjdk24. Haven't gone
through all the ancient version yet, as my focus is mainly on mainline,
and these days on openjdk25.

> I can commit this today to openjdk17 and if builds start to succeed to other openjdk* ports.

I'm in favour!

H!

 

  ------=_Part_12441_226741785.1757766372128--