Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 May 2007 03:26:06 -0400
From:      Parv <parv@pair.com>
To:        freebsd-rc@freebsd.org
Subject:   fwd: Re: X.org 7.2 ports merged into the FreeBSD Ports Tree
Message-ID:  <20070521072606.GA19214@holestein.holy.cow>

next in thread | raw e-mail | index | archive | help
--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello rc people,

Please CC me as I am not subscribed to -rc@ list.

Doug B suggested that I should forward my patch after I tried Doug's
patch.  In short, the patch resolves the paths in $local_startup and
removes duplicates, thus not running scripts twice when
/usr/{local,X11R6} point to same location.  See also
<20070520054309.GA3872@holestein.holy.cow> message on ports@ list
where setting $local_{startup,periodic} was the work around.

  - Parv

-- 


--C7zPtVaVf+AK4Oqc
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <owner-freebsd-ports@freebsd.org>
X-Envelope-To: parv@tenshian.pair.com
Delivered-To: freebsd-ports@FreeBSD.ORG
Date: Mon, 21 May 2007 02:11:14 -0400
From: Parv <parv@pair.com>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20070521061114.GA16252@holestein.holy.cow>
Mail-Followup-To: Doug Barton <dougb@FreeBSD.org>,
	Peter Jeremy <peterjeremy@optushome.com.au>, ports@FreeBSD.org,
	x11@FreeBSD.org
References: <464F62D8.80200@FreeBSD.org>
	<20070519215700.GC1164@turion.vk2pj.dyndns.org>
	<464F75BF.80203@FreeBSD.org>
	<20070519223641.GE1164@turion.vk2pj.dyndns.org>
	<20070520054309.GA3872@holestein.holy.cow>
	<4650BD2C.6060801@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="d6Gm4EdcadzBjdND"
Content-Disposition: inline
In-Reply-To: <4650BD2C.6060801@FreeBSD.org>
Cc: ports@FreeBSD.org, Peter Jeremy <peterjeremy@optushome.com.au>,
	x11@FreeBSD.org
Subject: Re: X.org 7.2 ports merged into the FreeBSD Ports Tree
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
Sender: owner-freebsd-ports@freebsd.org


--d6Gm4EdcadzBjdND
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

in message <4650BD2C.6060801@FreeBSD.org>,
wrote Doug Barton thusly...
>
>  Parv wrote:
> 
> > I am using FreeBSD 6.  I haven't tried xorg 7.2 port(s) yet, but
> > recently did merge /usr/X11R6 to /usr/local (programs reinstalled,
> > made link to X11R6 to local, and such).  On a reboot after that,
> > scripts indeed ran twice
...
> Could you try restoring the default rc.conf entry, and apply the
> patch I posted to /etc/rc.subr? It would be nice to get testing
> from someone who was actually affected by the problem.

Doug, after commenting out $local_{periodic,startup} lines in
/etc/rc.conf, the patch posted in message
<464F8AAF.2010609@FreeBSD.org> failed to stop double execution of
scripts.

I do not see how the statement on line 1490 ...


  1489  case "$local_rc" in
  1490  *[\ ]*${f}[\ ]*|*[\ ]*${f}) ;;
  1491  *) local_rc="${local_rc} $f" ;;
  1492  esac


... work without actually resolving the paths, at least in case of ...

  lrwxr-xr-x  1 root  wheel  11 May 16 16:30 /usr/X11R6@ -> /misc/local
  lrwxr-xr-x  1 root  wheel  11 Dec 21  2004 /usr/local@ -> /misc/local


... since 'X11R6' will always be different than 'local'.

Please look over the attached patch (where, at least in my case,
after resolving directories in $local_startup, already_seen function
calls can be omitted just before making file list).  The patch is
against this /etc/rc.subr version ...

  # $FreeBSD: src/etc/rc.subr,v 1.34.2.20 2007/03/16 15:34:09 yar Exp


  - Parv

-- 


--d6Gm4EdcadzBjdND
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--d6Gm4EdcadzBjdND--

--C7zPtVaVf+AK4Oqc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070521072606.GA19214>