From nobody Sat Nov 1 19:07:44 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4czS581svhz6Dl6g; Sat, 01 Nov 2025 19:06:52 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (www.zefox.net [50.1.20.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "pelorus.zefox.org", Issuer "pelorus.zefox.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4czS573KjWz3KtH; Sat, 01 Nov 2025 19:06:51 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Authentication-Results: mx1.freebsd.org; none Received: from www.zefox.net (localhost [127.0.0.1]) by www.zefox.net (8.18.1/8.18.1) with ESMTPS id 5A1J7jar077376 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 1 Nov 2025 12:07:45 -0700 (PDT) (envelope-from fbsd@www.zefox.net) Received: (from fbsd@localhost) by www.zefox.net (8.18.1/8.18.1/Submit) id 5A1J7iUh077375; Sat, 1 Nov 2025 12:07:44 -0700 (PDT) (envelope-from fbsd) Date: Sat, 1 Nov 2025 12:07:44 -0700 From: bob prohaska To: Adrian Chadd Cc: Mark Millard , freebsd-arm@freebsd.org, freebsd-current@freebsd.org Subject: Re: Buildkernel fails in /usr/obj/usr/src/arm.armv7/sys/GENERIC/vchiq_shim.o Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7065, ipnet:50.1.16.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4czS573KjWz3KtH On Sat, Nov 01, 2025 at 10:22:37AM -0700, Adrian Chadd wrote: > Here's my suggested solution: > > === > diff --git a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > index 96c3a0db8aa5..7e105a6b3b77 100644 > --- a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > +++ b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c > @@ -628,7 +628,9 @@ free_pagelist(BULKINFO_T *bi, int actual) > pagelist = bi->pagelist; > > vchiq_log_trace(vchiq_arm_log_level, > - "free_pagelist - %zx, %d (%u bytes @%p)", (size_t)pagelist, > actual, pagelist->length, bi->buf); > + "free_pagelist - %zx, %d (%lu bytes @%p)", > + (size_t)pagelist, (int)actual, (unsigned long)pagelist->length, > + bi->buf); > > num_pages = > (pagelist->length + pagelist->offset + PAGE_SIZE - 1) / > === A simple-minded copy/paste to a patchfile in /usr/src named vchiq.patch failed with # patch < vchiq.patch Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c |b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c |index 96c3a0db8aa5..7e105a6b3b77 100644 |--- a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c |+++ b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c -------------------------- Patching file sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c using Plan A... patch: **** malformed patch at line 11: actual, pagelist->length, bi->buf); I've refrained from tampering with the sources, did I do something else dumb, like not strip the a/ prefix from the diff line? I expected a "file not found" error in that case. For clarity, /etc/make.conf is absent, /etc/src-env.conf contains WITH_META_MODE= Thanks for the quick reply! bob prohaska