From owner-cvs-all@FreeBSD.ORG Mon Nov 1 15:29:18 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id ECCA516A4CE; Mon, 1 Nov 2004 15:29:17 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id iA1FTHdu023705; Mon, 1 Nov 2004 10:29:17 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id iA1FTGSn023704; Mon, 1 Nov 2004 10:29:16 -0500 (EST) (envelope-from green) Date: Mon, 1 Nov 2004 10:29:16 -0500 From: Brian Fundakowski Feldman To: Daniel Eischen Message-ID: <20041101152916.GV93831@green.homeunix.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 15:29:18 -0000 On Mon, Nov 01, 2004 at 09:31:10AM -0500, Daniel Eischen wrote: > On Sun, 31 Oct 2004, Daniel Eischen wrote: > > > On Sun, 31 Oct 2004, Brian Feldman wrote: > > > > > green 2004-10-31 05:03:50 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/libpthread/thread thr_mutex.c > > > Log: > > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > > packages expect and seems to be most correct according to the slightly- > > > ambiguous standards. > > > > > > MFC after: 1 month > > > Corroborated by: POSIX > > > Reviewed by: silence on threads@ > > > > I never saw this, and there has been a couple of long threads about > > it. The current behavior was deemed correct especially since default > > mutexes are error check mutexes. The rationale is that it provides a way > > for a thread to tell if it owns the mutex if EDEADLK is returned. > > > > Please back out and sorry for not seeing a posting on -threads. > > I retract the backout request. I have response from Dave Butenhof > over at the Austin Group mailing list, and EBUSY should be returned > even for error check mutexes. He acknolwedged the spec was not > clear and thought they had cleaned it up in that regard. So this > is the correct fix :-) Could you please remind me what the procedure is for including POSIX text within our manual pages? For pthreads it should be trivial to use almost the same text, since we didn't originate the interfaces ourselves, no? Thanks for checking this out at the source. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\