From owner-svn-src-head@FreeBSD.ORG Tue Sep 30 13:45:21 2014 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3597425E; Tue, 30 Sep 2014 13:45:21 +0000 (UTC) Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198]) by mx1.freebsd.org (Postfix) with ESMTP id 17DBFD3B; Tue, 30 Sep 2014 13:45:21 +0000 (UTC) Received: from bender.lan (97e07ab1.skybroadband.com [151.224.122.177]) by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id B16555CF66; Tue, 30 Sep 2014 13:38:07 +0000 (UTC) Date: Tue, 30 Sep 2014 14:37:58 +0100 From: Andrew Turner To: Andreas Tobler Subject: Re: svn commit: r272209 - in head/sys/arm: arm include Message-ID: <20140930143758.27d26ab9@bender.lan> In-Reply-To: <5429A58E.2030508@FreeBSD.org> References: <201409270957.s8R9vYrw056987@svn.freebsd.org> <5429A58E.2030508@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Andrew Turner , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2014 13:45:21 -0000 On Mon, 29 Sep 2014 20:31:42 +0200 Andreas Tobler wrote: > Hi Andrew, > > On 27.09.14 11:57, Andrew Turner wrote: > > Author: andrew > > Date: Sat Sep 27 09:57:34 2014 > > New Revision: 272209 > > URL: http://svnweb.freebsd.org/changeset/base/272209 > > > > Log: > > Add machine/sysreg.h to simplify accessing the system control > > coprocessor registers and use it in the ARMv7 CPU functions. > > > > The sysreg.h file has been checked by hand, however it may > > contain errors with the comments on when a register was first > > introduced. The ARMv7 cpu functions have been checked by compiling > > both the previous and this version and comparing the md5 of the > > object files. > > > > Submitted by: Svatopluk Kraus > > Submitted by: Michal Meloun > > Reviewed by: ian, rpaulo > > Differential Revision: https://reviews.freebsd.org/D795 > > > > Added: > > head/sys/arm/include/sysreg.h (contents, props changed) > > This one breaks kernel build with gcc-4.2.1. > > __ARM_ARCH not defined. On gcc-4.2.1 there is no __ARM_ARCH builtin. > Later gcc do have it. > > The include below fixes the build. Fixed in r272300. Andrew