From nobody Thu Jan 16 18:08:01 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YYrSf311Gz5kktL; Thu, 16 Jan 2025 18:08:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YYrSd5N6Xz3R9s; Thu, 16 Jan 2025 18:08:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737050881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hLwfgWId9MPLMCZJrlany1YrC1SxsExd26oTjEZ4ljA=; b=PtQL0nl+mvPmWdxI/TqzuR6FcuGxLt0ienIEDaEqJWYjv7OZ219doO1rhotZ6OhD672/nL 2HzdGc7Pk8U4QvDNge2PAovFdMQ0vQklhPwImlxN3U2CDsCZ1B4zho6UDJaaFEOP90vF7C CQ4FYr0FRioBR+mRV9m4hkw45Nvb70OkGtnZ9fL6xmmqjP9bMMuWl39MYnBz411L0HWiSM a++FPJzHkmSmRCvE/InvfFftDpI2FtiGrwCcV+SQBLhgsNnsE/+YDFUNuHi6cElZ9olcVO gESM3Yq8PD/TQ9/FDdqxuTCFDKco1WBft7/rlqtseEdwR6kBbC5x1XQD2yVhHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737050881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hLwfgWId9MPLMCZJrlany1YrC1SxsExd26oTjEZ4ljA=; b=MvF3WPnA7W9hteuKtsFtFEl6bjmPfLA8xTuqd2YXnex9nBrr14Wl/eSmxuIQwW1J5Q/Xg/ KAhbUXL+kQgobPsHPUxO4Idi72x2y8hSHuEHcbRm/tUdIY+rCI9NycFB3C2b1i0JJ6c5cA s51YZnl32mHAewLZlKcvIzd5vHKLO42X739h6IEar4xr6YydCwYVVXRTvVoXRKadsVWKmk wfhDb64MkrfGLZtwhMISM2HWNhKId5sDm9IdKaYYiSX1Xt4DL3gzW4cvFyS2Ryh3+9oPbi Ri3UNMy6tUwERxKG8Ioty+xzj3C3gj1eMXCiy35jwxQimPwPhyTwHIZzF/aP3A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737050881; a=rsa-sha256; cv=none; b=CY56fgrGNZrue7SVeZjvLioxTzBbwZmJ6ltfsR8YG3i6NgjQyuKrAlzFzDdZgXmhPwj4qy 4axDJ9B626F18qhIXzDquEzr8+T7ms2FvQGTtjYMQEnNP9iSOAZ/4UPs5yfTbjO3wU9DM2 XVtaYEJmAW4MQfyF7qJqtGofOvlRrzDO5XEpMKjnL5VcdvIM80oU1ls34eIpq1wPKcJAUQ tf/qlNgI85zofzF63TqKHjEjY9uTkPA1RrAe3sScpFR9ZcxQihPqZny+iZoRnmvujs6UG6 LB1A6VTQlbiE8oSQublbIpxEJNcDr38139KjpX+g2qJWTEEZcLYMVMh6cl6hLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YYrSd4xNFzkMx; Thu, 16 Jan 2025 18:08:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50GI81AJ091110; Thu, 16 Jan 2025 18:08:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50GI816N091107; Thu, 16 Jan 2025 18:08:01 GMT (envelope-from git) Date: Thu, 16 Jan 2025 18:08:01 GMT Message-Id: <202501161808.50GI816N091107@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 63abb6a3b5d4 - stable/14 - osd: Constify signature of osd_register() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 63abb6a3b5d499f4fcd7d10e891900ae09bfbb06 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=63abb6a3b5d499f4fcd7d10e891900ae09bfbb06 commit 63abb6a3b5d499f4fcd7d10e891900ae09bfbb06 Author: Olivier Certner AuthorDate: 2024-07-01 17:10:47 +0000 Commit: Olivier Certner CommitDate: 2025-01-16 18:06:52 +0000 osd: Constify signature of osd_register() This makes it clear that 'methods' (if not NULL) points to an array that won't be modified. Internally, this array is indeed copied into the given OSD type's larger array of all methods for all slots. Reviewed by: jamie Approved by: markj (mentor) MFC after: 5 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46886 (cherry picked from commit 4a26b63145a5e18610aa9050262e3b4f75aa7117) --- share/man/man9/osd.9 | 4 ++-- sys/kern/kern_osd.c | 2 +- sys/sys/osd.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/share/man/man9/osd.9 b/share/man/man9/osd.9 index 95547f5211c2..5e0e482914c3 100644 --- a/share/man/man9/osd.9 +++ b/share/man/man9/osd.9 @@ -23,7 +23,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd April 26, 2016 +.Dd October 07, 2024 .Dt OSD 9 .Os .Sh NAME @@ -49,7 +49,7 @@ .Fo osd_register .Fa "u_int type" .Fa "osd_destructor_t destructor" -.Fa "osd_method_t *methods" +.Fa "const osd_method_t *methods" .Fc .Ft void .Fo osd_deregister diff --git a/sys/kern/kern_osd.c b/sys/kern/kern_osd.c index 9f5803847d24..7073ee564301 100644 --- a/sys/kern/kern_osd.c +++ b/sys/kern/kern_osd.c @@ -91,7 +91,7 @@ osd_default_destructor(void *value __unused) } int -osd_register(u_int type, osd_destructor_t destructor, osd_method_t *methods) +osd_register(u_int type, osd_destructor_t destructor, const osd_method_t *methods) { void *newptr; u_int i, m; diff --git a/sys/sys/osd.h b/sys/sys/osd.h index 498cad5064f9..5d59ce5a3d9a 100644 --- a/sys/sys/osd.h +++ b/sys/sys/osd.h @@ -55,7 +55,7 @@ typedef void (*osd_destructor_t)(void *value); typedef int (*osd_method_t)(void *obj, void *data); int osd_register(u_int type, osd_destructor_t destructor, - osd_method_t *methods); + const osd_method_t *methods); void osd_deregister(u_int type, u_int slot); int osd_set(u_int type, struct osd *osd, u_int slot, void *value);