Date: Sun, 05 Dec 2004 23:19:39 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Nate Lawson <nate@root.org> Cc: "M. Warner Losh" <imp@bsdimp.com> Subject: Re: cvs commit: src/sys/dev/acpica acpi.c Message-ID: <68311.1102285179@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 05 Dec 2004 14:16:38 PST." <41B388C6.5090409@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <41B388C6.5090409@root.org>, Nate Lawson writes: >M. Warner Losh wrote: >> In message: <200412050135.iB51ZJJl040909@repoman.freebsd.org> >> Nate Lawson <njl@FreeBSD.org> writes: >> : If we are resuming non-MPSAFE drivers, they need Giant held for them. >> >> Generally, when walking the device tree, one must have Giant. I've >> been meaning to add asserts for this in the tree... I think that we >> have enough things giant is pushed out of that it is time... > >I'd like that. I think the GIANT_REQUIRED asserts should go in the >root_bus suspend/resume/shutdown methods, not in acpi. This will cover >everyone unless a driver drops Giant and doesn't reacquire it (unlikely). In Geom I assert after I call driver methods, just to catch that case as well. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?68311.1102285179>