From nobody Wed May 28 10:29:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b6m2s1g76z5xHS8; Wed, 28 May 2025 10:29:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b6m2s16bZz3ZY1; Wed, 28 May 2025 10:29:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748428181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NI5leqZhXh9KmiGbdKS83rVdLeiSHL2mSdH2icENgRw=; b=ez+DnF6rYwbXaCrOz7LkcjBuD4Q6hfhxU5E2JUD/WhqjF3l6u+QbW9j0ZuAZsLpRAzT4TE WMEv869pgtpt1VS2UiRYe2RPsZ/s2sq9y0Hogsq8TARIt+iaFkDGzuTPHMqcKRb1jcG07P /eQ5QEBrQhfpB5LxDjSYSJZm7PFDwy/Msq68Jk2IOEFmTd6n0YFYdS/ShEWvvWDmc+frrm /0Uqx6G7lnacY16SoF3ooPGlgBazNr4MTg5Xq5ky8CP6QAVndaQQaMp4E85nsLXaccxPdm XuR5pI3OqLK40yjjxb+zCmdE8mCk8cdD34T1Vlf0i6JcDX2q+v7ymPU99UY9Mw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748428181; a=rsa-sha256; cv=none; b=WOSpp4hw6k4N2f0Atnx23Nm47YCH9Rl5FYBH1ma0N9OahikVfXmGkKtiMmV99/TGbppdgb xDTU3y2MCDfvlV1etYVKUGtEFgwrSxfMoZ0i62Dc5gOf3hErCeIi26fUh6Pb6IWpTgwTtR F+M78X9J8ZGG2pnEfOR9F1+pDxTIFXtORaZnI7O/yQF8X2vbSzasIxY729tKdvNZHlEt6e 9WPaWy6YyVxtiJRPVB+1ORhksHIwB+0VDEbShCYZDDZyiFdLF07Fy2oAvwVgQDW0kfELh0 wTJycXHGIqG+UuuHTKZhfZauTUvJgJm94qKiptQPQhDhS4Ym0qRd2RxiG2j3Eg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748428181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NI5leqZhXh9KmiGbdKS83rVdLeiSHL2mSdH2icENgRw=; b=bSo++ojlyt1hLiw0bKVvUQ71fekQuy+NeXlWK0RLBG2/QY1H5Vh8AymZMwiU++VfghjB/b lM70HiQ9TaOkXp+m6VnSLxZv9Ytjd2S6ND4ErsKc7LdNZh3srfCFYM0mWLQGavX7BhcLF4 yzaysH/QqUAzRbvrRsVui9uKFUizWBNoMdFLb8EU6l6hgH/GsTVZqk93Tk9PHDrkxfzfmf FnyDT2e6hZ/mcF1EfqMNko8r309M13N2HD597U4ihsEpL161ehXOFTjSrMa0UsCR8iziSL gJrZJqZI7RW39lMmbZCbYQ0o+/lHysgvscYo3ZXNiQNUJsF6YwLnVa+aEpNX+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b6m2s0hD8zZxB; Wed, 28 May 2025 10:29:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54SATeMN062973; Wed, 28 May 2025 10:29:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54SATeWD062970; Wed, 28 May 2025 10:29:40 GMT (envelope-from git) Date: Wed, 28 May 2025 10:29:40 GMT Message-Id: <202505281029.54SATeWD062970@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: f1430567f26b - main - ddb: add show all tcpcbs List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f1430567f26bc84db3818914fa91c74507d1602a Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=f1430567f26bc84db3818914fa91c74507d1602a commit f1430567f26bc84db3818914fa91c74507d1602a Author: Michael Tuexen AuthorDate: 2025-05-28 10:25:26 +0000 Commit: Michael Tuexen CommitDate: 2025-05-28 10:25:26 +0000 ddb: add show all tcpcbs Add a command to show all TCP control blocks. Also provide an option to limit the output to TCP control blocks, which are locked. The plan is to run show all tcpcbs/l when syzkaller triggers a panic. If a TCP control block is affected, it is most likely locked and therefore the command shows the information of the affected TCP control block. Reviewed by: markj, thj Tested by: thj MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D50516 --- share/man/man4/ddb.4 | 10 +++++++++- sys/netinet/tcp_usrreq.c | 23 +++++++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/share/man/man4/ddb.4 b/share/man/man4/ddb.4 index 4f6304e88114..9a9af553b29d 100644 --- a/share/man/man4/ddb.4 +++ b/share/man/man4/ddb.4 @@ -24,7 +24,7 @@ .\" any improvements or extensions that they make and grant Carnegie Mellon .\" the rights to redistribute these changes. .\" -.Dd May 24, 2025 +.Dd May 28, 2025 .Dt DDB 4 .Os .Sh NAME @@ -604,6 +604,14 @@ The modifier will print command line arguments for each process. .\" .Pp +.It Ic show Cm all tcpcbs Ns Op Li / Ns Cm l +Show the same output as "show tcpcb" does, but for all +TCP control blocks within the system. +Using the +.Cm l +modifier will limit the output to TCP control blocks, which are locked. +.\" +.Pp .It Ic show Cm all trace .It Ic alltrace Show a stack trace for every thread in the system. diff --git a/sys/netinet/tcp_usrreq.c b/sys/netinet/tcp_usrreq.c index 5be4c399893a..a7a1d98fd193 100644 --- a/sys/netinet/tcp_usrreq.c +++ b/sys/netinet/tcp_usrreq.c @@ -3222,4 +3222,27 @@ DB_SHOW_COMMAND(tcpcb, db_show_tcpcb) db_print_tcpcb(tp, "tcpcb", 0); } + +DB_SHOW_ALL_COMMAND(tcpcbs, db_show_all_tcpcbs) +{ + VNET_ITERATOR_DECL(vnet_iter); + struct inpcb *inp; + bool only_locked; + + only_locked = strchr(modif, 'l') != NULL; + VNET_FOREACH(vnet_iter) { + CURVNET_SET(vnet_iter); + CK_LIST_FOREACH(inp, &V_tcbinfo.ipi_listhead, inp_list) { + if (only_locked && + inp->inp_lock.rw_lock == RW_UNLOCKED) + continue; + db_print_tcpcb(intotcpcb(inp), "tcpcb", 0); + if (db_pager_quit) + break; + } + CURVNET_RESTORE(); + if (db_pager_quit) + break; + } +} #endif