From owner-cvs-all Mon Nov 1 14:52:22 1999 Delivered-To: cvs-all@freebsd.org Received: from jade.chc-chimes.com (jade.chc-chimes.com [216.28.46.6]) by hub.freebsd.org (Postfix) with ESMTP id 7BEB114DC4; Mon, 1 Nov 1999 14:52:18 -0800 (PST) (envelope-from billf@chc-chimes.com) Received: by jade.chc-chimes.com (Postfix, from userid 1001) id 75DF11C2B; Mon, 1 Nov 1999 16:54:31 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by jade.chc-chimes.com (Postfix) with ESMTP id 7241F3837; Mon, 1 Nov 1999 16:54:31 -0500 (EST) Date: Mon, 1 Nov 1999 16:54:31 -0500 (EST) From: Bill Fumerola To: Nate Williams Cc: Chris Costello , "Rodney W. Grimes" , Chris Costello , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/mergemaster Makefile mergemaster In-Reply-To: <199911012236.PAA19584@mt.sri.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Mon, 1 Nov 1999, Nate Williams wrote: > Yes he did. What's the point of emailing out commit logs if everyone > still has to go look at the diffs. > > Commit email should be self-explanatory and not need to review the diffs > to see *what* was done. The diffs are there to see *how* something was > done. Nate, The commitlog said _exactly_ what Chris did. It should be assumed that he did it like the 30 other Makefiles that do the EXACT SAME FUCKING THING. When I upgrade my next port I will use as my commit message: "First I found out there was a new release of this software, then I downloaded it and regenerated the md5 checksum. After trying to compile it, I found some errors that weren't there before. So I made local changes and used diff -ruN foo.c.old foo.c to generate a patch that I placed in patches/. I used cvs add on this patch and then after tweaking the makefile, I fixed the packing list, boy was that a pain. After fixing some old errors, I'm now committing this with cvs ci" OR "Upgrade to x.y, make associated changes" I've done the latter ever since I got my commit bit. I am amazed at the petty shit that this list has sunk to bitching about. -- - bill fumerola - billf@chc-chimes.com - BF1560 - computer horizons corp - - ph:(800) 252-2421 - bfumerol@computerhorizons.com - billf@FreeBSD.org - To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message