Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jul 1999 14:02:51 +0100
From:      Brian Somers <brian@FreeBSD.org.uk>
To:        "David E. O'Brien" <obrien@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/yacc skeleton.c 
Message-ID:  <199907291302.OAA28755@keep.lan.Awfulhak.org>
In-Reply-To: Your message of "Thu, 29 Jul 1999 02:42:15 PDT." <199907290942.CAA82626@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
obrien@FreeBSD.org said:
> obrien      1999/07/29 02:42:15 PDT
>   Modified files:
>     usr.bin/yacc         skeleton.c 
>   Log:
>   * Don't assume realloc() can take NULL as first arg.  Yacc needs to
>     generate portable code...
 
Why is this necessary ?  Now we have code that checks for the realloc 
pointer being NULL twice.

I agree that this change should be part of any ``portable yacc'' 
code (if such a thing exists), but can't see why the change is necessary 
in the FreeBSD tree.

I don't object to the extent that I think it should be backed out, this 
just shouldn't make a precedent IMHO.

-- 
Brian <brian@Awfulhak.org>                        <brian@FreeBSD.org>
      <http://www.Awfulhak.org>;                   <brian@OpenBSD.org>
Don't _EVER_ lose your sense of humour !          <brian@FreeBSD.org.uk>




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907291302.OAA28755>