From nobody Sun Sep 21 18:56:56 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cVFpg0S5wz67pGB; Sun, 21 Sep 2025 18:56:59 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cVFpf73lYz3NFh; Sun, 21 Sep 2025 18:56:58 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758481019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FKvFhi9OSgPMykEtLoUsmuADvdqChonvLzcj/D8u4lI=; b=YS1FpCxbXG+yjLdvD4AOWYhBzk/shahxBFFFR+dTrfN6zMw9JZ7eouONL+wgvKVqcghGYJ 1VisxLe4mwWgoEns7c19pSZK3V1OB/0jBI6JTq4byvI88FEUFx+HH3xGvFiaCsOMcAFq1l erj5IlS82EwGa0jjwuCYlVsTTzpL/7EAh9qNhrb5tBboKkNUcfHf9DHkh2COHGBYtDNgb2 onWIXMN/8aHr8c5a1ss0nNSH5eD1bCGk4fH+maXiIMGvoEua8oAml+d1gV8TrkCZVflyct UGfjbDmGT352i0Ig4nFhiaK8sa7f/WHNHdRTjTlmQmv9/BdkW8ZoMRFQbWsjBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758481019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FKvFhi9OSgPMykEtLoUsmuADvdqChonvLzcj/D8u4lI=; b=KBr7eTdc1rMmOwV9CAvYNdMa+Ty+942JS1yDOukDMUiOVrVeXt32XDyTW426q1Y6Z5ZooP U3mOdUNshByf4qRBSWa+l/OpGP9p7hJhhiDER+33EHemyl7Dp4QrkbfNoLJmVKAvwUMY1V vGuhWMroWvrILGVZ0SX13TdilgZp7kD6GJrwCvj8B1DmZZMIYIJO7SgiVfHNcRdgkVlQG8 uUWYcc1g3tPVPSa+dLzEQZCNhFpGDlGsdPZNC8GtQqMLY72nt9ZeWfGI21iFcB3Uenonqr cOu18+3ZgrywO+JU8m9/Mx6XcxSoOQGgGad8kjL6oJu5AKNj3A93V75T8+yO2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758481019; a=rsa-sha256; cv=none; b=Mwl1V9EDtv4UMP1ie+JSCA/YpEyrUZTgR7AiIvwTuRIYDvm/d6U9NOhu98LTOH+T4+gBuk MIFKWd1qG22w+piPqz/R2AYs5pqrxrhO3EqB4wbhhJ+T++z8qr+VTi7t9DP2vVOXgCLqom iPO6vD+bznekXkmF6Nay6YK1EmdOHiW3XmvHQ+nDa4Bh0c/92JEbmKGjSG2b68ZJkjwJLi +GTqvNVpqQB8hIbKb8GWe15LVcSma2qHjDx+bC8K3761yWsaRk8lk41lU+4CRhAiHmaUie b9J/qLyPYsBQkConmNTuLVDu5gc7gjRQFaizjRQgnRxv3PaE2wfPVarpRZtCYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cVFpf2XHKzCQm; Sun, 21 Sep 2025 18:56:58 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Sun, 21 Sep 2025 11:56:56 -0700 From: Gleb Smirnoff To: Guido Falsi Cc: "Herbert J. Skuhra" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 31ec8b6407fd - main - sys/netinet6: Implement RFC 7217 Message-ID: References: <202509201231.58KCVqBC047480@gitrepo.freebsd.org> <874iswhip4.wl-herbert@gojira.at> <07503de1-785e-4e4d-b4e4-0524aeb064e1@FreeBSD.org> <87jz1sc9fr.wl-herbert@gojira.at> <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org> On Sun, Sep 21, 2025 at 06:02:24PM +0200, Guido Falsi wrote: G> A C program would have included the system include and noticed the change, G> but this software has hardcoded the struct in go code and requires G> patching. G> G> I'm attaching a simple patch for the ports tree for this port, it compiles G> but I've not tested it at runtime, could you try applying this patch to the G> ports tree and recompile the port, and report back? G> G> Please note this is not a proper patch for the ports tree, it just fixes G> the problem, but would break it for anyone else, I'll produce a proper G> patch for the ports tree once I have confirmed the approach woks. Is struct nd_ifinfo something that is used as argument to ioctl(2)? If so, then adding counter_u64_t into it is not correct. I would suggest to not revert the change as a whole, but remove the counter only and bring struct nd_ifinfo back to original. The counter should probably go into struct in6_ifextra that is pointed by if->if_afdata[AF_INET6]. -- Gleb Smirnoff