From owner-cvs-sys Sat Apr 27 20:38:05 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id UAA01226 for cvs-sys-outgoing; Sat, 27 Apr 1996 20:38:05 -0700 (PDT) Received: from spinner.DIALix.COM (spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id UAA01216 Sat, 27 Apr 1996 20:37:48 -0700 (PDT) Received: from spinner.DIALix.COM (localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.7.5/8.7.3) with ESMTP id LAA10519; Sun, 28 Apr 1996 11:37:14 +0800 (WST) Message-Id: <199604280337.LAA10519@spinner.DIALix.COM> X-Mailer: exmh version 1.6.6 3/24/96 To: Bruce Evans cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, joerg@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/conf Makefile.i386 In-reply-to: Your message of "Sun, 28 Apr 1996 02:17:09 +1000." <199604271617.CAA00220@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain Date: Sun, 28 Apr 1996 11:37:14 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Modified: sys/i386/conf Makefile.i386 >> Log: >> Make `install' depend on `kernel'. Some idiot tried to install a >> non-built kernel and complained in Usenet... :-) > >This was consistent with thousands of other Makefiles in the system. >It is a feature for `make install' to not build anything. > >Bruce And a highly desirable feature, some of us build with one uid and install with root later on and do not want to have root running stuff changing ownerships of files on us. Also, I NFS mount my build trees and do 'make reinstall' to install a coherent build on three machines, and really enjoy not having all the 'make installs' try and build stuff if I cross over a CTM delta boundry or something. (Yes, I know this does not affect the commit in question). However, the only place that this rule is "broken" that I'm aware of is the bsd.sgml.mk file which tries to reformat the html/ascii/etc files at install time. As for this commit, I'd suggest that it'd be better to test for the existance of the kernel before installing it, rather than using a 'make' dependency. ie, something like this: install: @if [ ! -f kernel ]; then echo "Build the kernel first!"; exit 1; fi .. rest of install.. Cheers, -Peter