From owner-freebsd-standards  Wed Apr 10  7:50:21 2002
Delivered-To: freebsd-standards@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 1CBF937B41B
	for <freebsd-standards@hub.freebsd.org>; Wed, 10 Apr 2002 07:50:04 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g3AEo4k99545;
	Wed, 10 Apr 2002 07:50:04 -0700 (PDT)
	(envelope-from gnats)
Date: Wed, 10 Apr 2002 07:50:04 -0700 (PDT)
Message-Id: <200204101450.g3AEo4k99545@freefall.freebsd.org>
To: freebsd-standards@FreeBSD.org
Cc: 
From: Mike Barcroft <mike@FreeBSD.org>
Subject: Re: standards/36950: Add -n to renice(8)
Reply-To: Mike Barcroft <mike@FreeBSD.org>
Sender: owner-freebsd-standards@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-standards.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-standards>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-standards>
X-Loop: FreeBSD.ORG

The following reply was made to PR standards/36950; it has been noted by GNATS.

From: Mike Barcroft <mike@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: standards/36950: Add -n to renice(8)
Date: Wed, 10 Apr 2002 10:41:49 -0400

 Tim J. Robbins <tim@robbins.dropbear.id.au> writes:
 >  On Wed, Apr 10, 2002 at 04:16:02AM -0000, Peter Avalos wrote:
 >
 >  > Index: renice.c
 >  > ===================================================================
 >
 >  > -static const char copyright[] =
 >  > +static char copyright[] =
 >
 >  I believe this should stay const. You could consider using the __COPYRIGHT
 >  macro, but \n's in its argument don't work properly.
  
 Vendor copyrights should be left in their original form.  Adding
 `const' here is a necessary evil in order prevent diagnostics on
 modern compilers.
  
 >  > -  printf("%d: old priority %d, new priority %d\n", who, oldprio, prio);
 >  > +  printf("%d: old nice_value %d, new nice_value %d\n", who, oldprio,
 +prio);
 >
 >  This should just be removed alltogether - SUSv3 specifies that standard
 >  output is not used at all, despite this being traditional behaviour.
  
 I'm not sure of the impact to the existing userbase, but I agree that
 this diagnostic is very unbecoming (particularly since it's outputted
 to stdout instead of stderr).
 
 Best regards,
 Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message