Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 Mar 2001 01:09:52 +0900 (JST)
From:      mistral@imasy.or.jp
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jkoshy@freebsd.org
Subject:   ports/26075: xli bugfix patch 
Message-ID:  <200103251609.f2PG9qs02645@mistral.imasy.or.jp>

next in thread | raw e-mail | index | archive | help

>Number:         26075
>Category:       ports
>Synopsis:       xli displays white screen when zoomed image is larger than display
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 25 08:20:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Yoshihiko Sarumaru
>Release:        FreeBSD 4.3-RC i386
>Organization:
>Environment:
System: FreeBSD mistral.imasy.or.jp 4.3-RC FreeBSD 4.3-RC #3: Fri Mar 23 15:40:40 JST 2001 yohta@mistral.imasy.or.jp:/usr/obj/usr/src/sys/PCG-505R i386


	
>Description:
	xli (xsetbg) can display image file with any zoom ratio.
	But if zoomed image is larger than display, it failed to clip it,
	because atx and aty overflow.
	I send a patch for the author one month before and he accept and agree
	with my patch, but he have not released bugfixed version.
>How-To-Repeat:
	fetch http://www.jp.FreeBSD.org/images/daemon1.jpg
	xsetbg -onroot -fullscreen daemon1.jpg (on 800x600 display)
>Fix:

--- xli.c.orig	Wed Feb  9 18:23:35 2000
+++ xli.c	Wed Feb 21 21:04:43 2001
@@ -369,8 +369,8 @@
 				winheight = globals.dinfo.height;
 
 			if (!images[0].ats) {
-				atx = (winwidth - inew->width) / 2;
-				aty = (winheight - inew->height) / 2;
+				atx = (int)(winwidth - inew->width) / 2;
+				aty = (int)(winheight - inew->height) / 2;
 			}
 			/* use clip to put border around image */
 			itmp = clip(inew, -atx, -aty, winwidth, winheight,
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103251609.f2PG9qs02645>