From owner-freebsd-net@freebsd.org  Wed Apr 27 02:09:24 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E342B1DCE9
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Wed, 27 Apr 2016 02:09:24 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org
 [IPv6:2610:1c1:1:607c::16:b])
 by mx1.freebsd.org (Postfix) with ESMTP id 6717A146E
 for <freebsd-net@freebsd.org>; Wed, 27 Apr 2016 02:09:24 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346)
 id C2818DBFA; Wed, 27 Apr 2016 02:09:23 +0000 (UTC)
Date: Wed, 27 Apr 2016 02:09:23 +0000
To: freebsd-net@freebsd.org
From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org>
Reply-to: D5872+325+9dea0574509cdbb3@reviews.freebsd.org
Subject: [Differential] D5872: tcp: Don't prematurely drop receiving-only
 connections
Message-ID: <0f002fdd5bd167a82c517508b26d009b@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D5872: tcp: Don't prematurely drop receiving-only connections
X-Herald-Rules: <64>
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-To: <PHID-USER-aojo5yplx3m2nkpgwndr>
X-Phabricator-To: <PHID-USER-57eqaez2c2qhlyhs4xoi>
X-Phabricator-To: <PHID-USER-4lzxzqflpaankb5hk2y4>
X-Phabricator-To: <PHID-USER-dyyyzfp34mimhzvg33tk>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-To: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
X-Phabricator-To: <PHID-PROJ-u7z45dkhkb4gc5luse77>
X-Phabricator-Cc: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-Cc: <PHID-USER-x2wszzhtr5egla5eo3md>
X-Phabricator-Cc: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
Thread-Index: MmVmNzYzNzljOGQxMmM4MWI4MmNjYzcxMzczIFcgH1M=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.21
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2016 02:09:24 -0000

sepherosa_gmail.com added a comment.


  In https://reviews.freebsd.org/D5872#128542, @mike-karels.net wrote:
  
  >   btw, I think the line to set the snd_cwnd should remain for now, until something replaces it.  ENOBUFS signals local congestion.
  
  
  Well, resetting the cwnd can be unfair for the connections encounters the ENOBUFS, since the underlying hardware can be flooded by other connections.  So I'd remove that cwnd resetting upon ENOBUFS.  We can open another discussion after fixing this issue first.

REVISION DETAIL
  https://reviews.freebsd.org/D5872

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, lstewart, hiren, jtl, transport
Cc: gnn, mike-karels.net, jtl