Date: Wed, 31 Jan 2024 16:33:53 +0100 From: Moin Rahman <bofh@freebsd.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9f0ce98efea9 - main - irc/rbot: Moved man to share/man Message-ID: <D2AFD878-E45E-4B2B-B08D-F3BCC500216B@freebsd.org> In-Reply-To: <a5088320-b479-40b3-bf17-6edc5fe8e3e3@FreeBSD.org> References: <202401291954.40TJsWBe042649@gitrepo.freebsd.org> <06e37dcd52f33a4fda060d86048e629f@FreeBSD.org> <A18D1794-A995-4E6D-98ED-44B52E581674@freebsd.org> <7b83c2c7-5048-409c-a55f-666c10086d71@FreeBSD.org> <a5088320-b479-40b3-bf17-6edc5fe8e3e3@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_835DA9AA-11A6-4111-930E-B791963768FF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jan 31, 2024, at 4:25 PM, Bryan Drewery <bdrewery@FreeBSD.org> = wrote: >=20 > On 1/31/2024 7:23 AM, Bryan Drewery wrote: >> On 1/31/2024 7:09 AM, Moin Rahman wrote: >>>=20 >>>=20 >>>> On Jan 31, 2024, at 3:51 PM, Bryan Drewery <bdrewery@FreeBSD.org> = wrote: >>>>=20 >>>> On 2024-01-29 11:54, Muhammad Moinur Rahman wrote: >>>>> The branch main has been updated by bofh: >>>>> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D9f0ce98efea9ca39d4930569c7a072= a9431793b2 >>>>> commit 9f0ce98efea9ca39d4930569c7a072a9431793b2 >>>>> Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> >>>>> AuthorDate: 2024-01-29 18:03:32 +0000 >>>>> Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> >>>>> CommitDate: 2024-01-29 19:54:13 +0000 >>>>> irc/rbot: Moved man to share/man >>>>=20 >>>> I think you should be testing these before committing. This one = doesn't use GNU configure. >>> What makes you think that my commits are not well tested? >>> This was when I committed: >>> = https://pkg.bofh.network/data/132-default/2024-01-29_19h19m37s/logs/rbot-2= 0160325_2,1.log >>>=20 >>> This is now: >>> = https://pkg.bofh.network/data/132-default/2024-01-31_16h01m20s/logs/rbot-2= 0160325_2,1.log >>>=20 >>> GNU_CONFIGURE_MANPREFIX has nothing to do with GNU_CONFIGURE itself = and it is mainly passed >>> as a var to CONFIGURE_ARGS. >> GNU_CONFIGURE_MANPREFIX absolutely only has to do with GNU_CONFIGURE. = Check bsd.port.mk. >> ~/git/ports/main/irc/rbot # make -V CONFIGURE_ARGS >> --prefix=3D/usr/local >> ~/git/ports/main/irc/rbot # make -V __LATE_CONFIGURE_ARGS >> __LATE_CONFIGURE_ARGS only includes GNU_CONFIGURE_MANPREFIX if = `./configure --help` shows a mandir. >> Do you have output in either of those? >=20 > or CONFIGURE_CMD? > ~/git/ports/main/irc/rbot # make -V CONFIGURE_CMD > ./configure >=20 > The only way it could work for you is if that says "ruby setup.rb" = which doesn't make sense since ruby.mk does not set that, it uses = ruby-setup-configure target. >=20 > This is required to build for me: >=20 > diff --git irc/rbot/Makefile irc/rbot/Makefile > index 06984ff5bcfc..0d9304566079 100644 > --- irc/rbot/Makefile > +++ irc/rbot/Makefile > @@ -25,8 +25,7 @@ LIB_DEPENDS=3D = libtokyocabinet.so:databases/tokyocabinet >=20 > USES=3D cpe ruby:setup >=20 > -GNU_CONFIGURE_MANPREFIX=3D ${PREFIX}/share > -CONFIGURE_ARGS=3D --prefix=3D${PREFIX} > +CONFIGURE_ARGS=3D --prefix=3D${PREFIX} = --mandir=3D${PREFIX}/share/man > NO_ARCH=3D yes >=20 > USE_GITHUB=3D yes >=20 >>>=20 >>>> =3D=3D=3D> Building rbot-20160325_2,1 >>>> pkg-static: Unable to access file = /wrkdirs/usr/ports/irc/rbot/work/stage/usr/local/share/man/rbot.xml.gz:No = such file or directory >>>> *** Error code 1 >>> This is not reproducible in latest ports tree at least. >>>=20 >>>>=20 >>>>> Approved by: portmgr (blanket) >>>>> --- >>>>> irc/rbot/Makefile | 3 ++- >>>>> irc/rbot/pkg-plist | 2 +- >>>>> 2 files changed, 3 insertions(+), 2 deletions(-) >>>>> diff --git a/irc/rbot/Makefile b/irc/rbot/Makefile >>>>> index aca35f99db58..06984ff5bcfc 100644 >>>>> --- a/irc/rbot/Makefile >>>>> +++ b/irc/rbot/Makefile >>>>> @@ -1,6 +1,6 @@ >>>>> PORTNAME=3D rbot >>>>> PORTVERSION=3D 20160325 >>>>> -PORTREVISION=3D 1 >>>>> +PORTREVISION=3D 2 >>>>> PORTEPOCH=3D 1 >>>>> CATEGORIES=3D irc ruby >>>>> @@ -25,6 +25,7 @@ LIB_DEPENDS=3D = libtokyocabinet.so:databases/tokyocabinet >>>>> USES=3D cpe ruby:setup >>>>> +GNU_CONFIGURE_MANPREFIX=3D ${PREFIX}/share >>>>> CONFIGURE_ARGS=3D --prefix=3D${PREFIX} >>>>> NO_ARCH=3D yes >>>>> diff --git a/irc/rbot/pkg-plist b/irc/rbot/pkg-plist >>>>> index e411686f8392..dfe970ca87da 100644 >>>>> --- a/irc/rbot/pkg-plist >>>>> +++ b/irc/rbot/pkg-plist >>>>> @@ -42,7 +42,7 @@ bin/rbotdb >>>>> %%RUBY_SITELIBDIR%%/rbot/registry/tc.rb >>>>> %%RUBY_SITELIBDIR%%/rbot/rfc2812.rb >>>>> %%RUBY_SITELIBDIR%%/rbot/timer.rb >>>>> -man/rbot.xml.gz >>>>> +share/man/rbot.xml.gz >>>>> %%DATADIR%%/contrib/plugins/stats.rb >>>>> %%DATADIR%%/contrib/plugins/vandale.rb >>>>> %%DATADIR%%/filters/rss.rb >>>=20 >=20 > -- > Bryan Drewery At this point I really do not have the time to seek individual ports = with this much details as I am doing all massive changes which are = tested at least in my side with poudriere and which works. Yes there are = cases where it regresses other ports which I am fixing too. If you think this port is useful to you change it as per your = requirements. Kind regards, Moin --Apple-Mail=_835DA9AA-11A6-4111-930E-B791963768FF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmW6aGFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJE/7g//QLZ4+rmXraU5No+iJp0NSQj9aC2pfEOCs+jksPszqtG/etv2uyjSdoHJ o94d8IgC9QEYvavUXi6yGwlfg6IeX8L64RYl7GGCxLboVx3rwGHFgsHqOKhBX6mq C0ZQwGY7Adioa9xvuYLyTbPkW/SEMY7OSG6F63A+IZN9LklQMEKXDrkjGTlOqzt+ wmCiaTKkpKz8DoqrvXP9U0g2mamG8W1zPhtDP9bXjn8OuUw2Ph5H4VFoAW2Ilh0w BXZOMBHNEGpxAYLS4xO1KBhTg9urcXAhqKTJeKdYb5RCCm2nNuVOuw3P/VkPW22+ RYbvabdFSY7CtJl7uhGYWte5ae3DqZ755dfEqDjUixf8ufUxQC7hCsbYjK7EPGIi d2gNRMlR/dbD2nsDwbDcFNjBywMkTTehQiVsTRidliWpI4fmtZbE8I4OZn7LzpEr C9xQ6cVyXhyiPLrMoEf2cyiUuhc4m6wmuqUMQgtCCSlPASq9cJuYow4zYwh2yaqg CvwOHBJxg0F9RPRF7wrWHpy1oWUAHwgoJvyKVlRRtXNFFRqo6t1mOSiktrs0JSaZ 3hRnDtNk11ra4RQbDjYTIOL8YjfkJa1Bb+iDQ3FgAo79RQA9yCX9X300JSWqCq+B 3lldZcqiFUFx0uaosXAzwAF6UbT43Khj/NOEsGZR15ILi3pnots= =Rkdr -----END PGP SIGNATURE----- --Apple-Mail=_835DA9AA-11A6-4111-930E-B791963768FF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D2AFD878-E45E-4B2B-B08D-F3BCC500216B>