From owner-svn-src-all@FreeBSD.ORG Wed Jun 2 09:34:42 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 754351065674; Wed, 2 Jun 2010 09:34:42 +0000 (UTC) (envelope-from uqs@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 653548FC1B; Wed, 2 Jun 2010 09:34:42 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o529Yg5M010518; Wed, 2 Jun 2010 09:34:42 GMT (envelope-from uqs@svn.freebsd.org) Received: (from uqs@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o529Ygti010516; Wed, 2 Jun 2010 09:34:42 GMT (envelope-from uqs@svn.freebsd.org) Message-Id: <201006020934.o529Ygti010516@svn.freebsd.org> From: Ulrich Spoerlein Date: Wed, 2 Jun 2010 09:34:42 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208730 - head/bin/chio X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2010 09:34:42 -0000 Author: uqs Date: Wed Jun 2 09:34:41 2010 New Revision: 208730 URL: http://svn.freebsd.org/changeset/base/208730 Log: Zero struct before reading from it PR: 140384 Found by: clang static analyzer MFC after: 3 weeks Modified: head/bin/chio/chio.c Modified: head/bin/chio/chio.c ============================================================================== --- head/bin/chio/chio.c Wed Jun 2 08:43:18 2010 (r208729) +++ head/bin/chio/chio.c Wed Jun 2 09:34:41 2010 (r208730) @@ -1072,6 +1072,7 @@ find_element(char *voltag, uint16_t *et, /* Read in the changer slots */ if (cp.cp_nslots > 0) { + (void) memset(&cesr, 0, sizeof(cesr)); cesr.cesr_element_type = CHET_ST; cesr.cesr_element_base = 0; cesr.cesr_element_count = cp.cp_nslots;