From owner-cvs-src@FreeBSD.ORG Mon Jan 30 23:48:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CC6D16A420; Mon, 30 Jan 2006 23:48:06 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id DDDEF43D6D; Mon, 30 Jan 2006 23:48:05 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.53] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id k0UNm4D8024739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 30 Jan 2006 15:48:05 -0800 Message-ID: <43DEA5C3.7090002@root.org> Date: Mon, 30 Jan 2006 15:48:19 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Florent Thoumie References: <20060130202806.DCC7916A4CA@hub.freebsd.org> In-Reply-To: <20060130202806.DCC7916A4CA@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2006 23:48:06 -0000 Florent Thoumie wrote: > flz 2006-01-30 20:27:44 UTC > > FreeBSD src repository (ports committer) > > Modified files: > sys/cam/scsi scsi_da.c > sys/dev/usb umass.c usbdevs > Log: > - Add a scsi_da.c and a umass.c quirk for Genesys 6-in-1 Card Reader. > > --- src/sys/cam/scsi/scsi_da.c:1.185 Thu Jan 26 00:35:53 2006 > +++ src/sys/cam/scsi/scsi_da.c Mon Jan 30 20:27:44 2006 > @@ -427,6 +427,14 @@ > {T_DIRECT, SIP_MEDIA_REMOVABLE, "*" , "USB DISK*", > "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE > }, > + { > + /* > + * Genesys 6-in-1 Card Reader > + * No PR, reported by anders > + */ > + {T_DIRECT, SIP_MEDIA_REMOVABLE, "Generic*", "STORAGE DEVICE*", > + "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE > + }, > }; I think it's bad to deviate from the policy we've established for handling quirks. The reason why we need a PR is to track the following info: # Output of "camcontrol inquiry yourdevice" # Manufacturer name, model number, etc. # Transport type (FC, SCSI, USB, Firewire) # Output from dmesg for failed attach attempts # Output from dmesg for successful attach attempts (after quirk added) # Output of "usbdevs -v" with device attached # Valid email address An email address or posting is not enough since the user may discard the device later and it's tough to tell from the quirk itself exactly what device was causing the problem. Case in point: the quirk "Generic STORAGE DEVICE" you've added could match any number of devices. Was this only a particular Genesys product or do all their products have this issue? Without a way to track this info, it becomes impossible to decide. PRs are the best current way to track things. http://root.org/~nate/freebsd/scsi/quirks.html Please stick to the policy of collecting the necessary information to help future maintainers. -- Nate