From owner-freebsd-ports@FreeBSD.ORG Sun Sep 11 20:01:05 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E5041065675; Sun, 11 Sep 2011 20:01:05 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15]) by mx1.freebsd.org (Postfix) with ESMTP id 30CB08FC17; Sun, 11 Sep 2011 20:01:05 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76) (envelope-from ) id 1R2qD8-0002Ll-Kg; Mon, 12 Sep 2011 00:01:02 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 5C65BB84D; Mon, 12 Sep 2011 00:00:58 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id 231D0B846; Mon, 12 Sep 2011 00:00:58 +0400 (MSD) Date: Mon, 12 Sep 2011 00:00:58 +0400 From: Dmitry Marakasov To: freebsd-ports@freebsd.org Message-ID: <20110911200057.GA1934@hades.panopticon> References: <20110907032718.GJ42123@hades.panopticon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20110907032718.GJ42123@hades.panopticon> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: stas@FreeBSD.org, kde@FreeBSD.org, python@FreeBSD.org Subject: Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2011 20:01:05 -0000 * Dmitry Marakasov (amdmi3@amdmi3.ru) wrote: The patch is ready: http://people.freebsd.org/~amdmi3/ldflags.patch While it's mostly a bunch of similar changes, I'd like community eyes on specific important parts, namely Mk/ changes, python and ruby and generally all := assigns of *FLAGS, as these are dangerous (may refer variables which were not yet defined or which are changed later. However, I don't see any other way to prepend values instead of appending). -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru