From owner-freebsd-hackers Thu May 25 11:29:30 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103]) by hub.freebsd.org (Postfix) with ESMTP id 53B0737B65A for ; Thu, 25 May 2000 11:29:27 -0700 (PDT) (envelope-from k@numeri.campus.luth.se) Received: from numeri.campus.luth.se (localhost [127.0.0.1]) by numeri.campus.luth.se (8.9.3/8.9.3) with ESMTP id UAA14580; Thu, 25 May 2000 20:34:17 +0200 (CEST) (envelope-from k@numeri.campus.luth.se) Message-Id: <200005251834.UAA14580@numeri.campus.luth.se> X-Mailer: exmh version 2.1.1 10/15/1999 To: Alexander Langer Cc: hackers@FreeBSD.ORG Subject: Re: review request: truncate(1) In-reply-to: Your message of "Thu, 25 May 2000 16:52:43 +0200." <20000525165243.A84651@cichlids.cichlids.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 25 May 2000 20:34:17 +0200 From: Johan Karlsson Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At Thu, 25 May 2000 16:52:43 +0200, Alexander Langer wrote: >Thus spake Johan Karlsson (k@numeri.campus.luth.se): > >> Please sort the options in getopt and in the switch-statement. >> see style(9) for more style info. >> Please also use -Wall when compiling to catch all warnings > >True - forget about that. > >What about the other things, I mean non-stylistic but >functional/technical stuff? > I think it looks just fine and the program works like I expect it to. However, the man page does not mention that one have to also specify the wanted size of the file. /Johan K > >Alex > >-- >I need a new ~/.sig. > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message