From owner-svn-src-projects@FreeBSD.ORG Thu Jan 29 17:19:01 2015 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E0194C0 for ; Thu, 29 Jan 2015 17:19:01 +0000 (UTC) Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com [209.85.223.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A2989A42 for ; Thu, 29 Jan 2015 17:19:01 +0000 (UTC) Received: by mail-ie0-f174.google.com with SMTP id vy18so36385388iec.5 for ; Thu, 29 Jan 2015 09:18:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=keZUyflaid47MWUGTUU5tecQjKWj9yYQRLGQrpY19qA=; b=Z5/D3FVpuMm//vqbiSx9LcG14B5l/mY4ByneJuSb9TWWINcsEQXMiovTLl8vqkUczs e8vjQElLQzMoQlVpT8xn+oH5L9r+ldvSS1gDlkfjLP4jcNE6XMCLkbDXsnfqG7tW6Oe4 faG95T3RAV2Pm5P9r077UeoXqNlP4TQQi2L+9Hf05S+O32E6kVgyMvdo1LBk8mMZN5sQ H5yAo2IoaYjZHGbCH5l2x0pq3vPaVi32xUfFoE2onflpFeatRjoG6NTQDGgfGIN4NSZ9 n+LygzkffUKDlKk5W2mkMdk9qs6YsqFBN7ty5wgLBf6GbtntrAhzLJId+4L5tii3lYVl ovhw== X-Gm-Message-State: ALoCoQkE9ZaktE99s0npejkXuZj7iYlwgH8EeEG1hmU3kmgCQtzyGdDWqHlYQHnbZtjKsOolOTkl X-Received: by 10.107.148.206 with SMTP id w197mr1922905iod.73.1422551935552; Thu, 29 Jan 2015 09:18:55 -0800 (PST) Received: from sol.firepipe.net ([2601:1:ad80:db8:7271:bcff:fe83:9550]) by mx.google.com with ESMTPSA id w140sm4411457iod.13.2015.01.29.09.18.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2015 09:18:54 -0800 (PST) Sender: Will Andrews Date: Thu, 29 Jan 2015 10:18:52 -0700 From: Will Andrews To: Garrett Cooper Subject: Re: svn commit: r277876 - in projects/zfsd/head/tests/sys/cddl/zfs/tests: cli_root/zpool_upgrade zil Message-ID: <20150129171841.GA23484@sol.firepipe.net> References: <201501291423.t0TENWOO048247@svn.freebsd.org> <2519DB92-D2AD-48BD-96AE-101168E9C163@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline In-Reply-To: <2519DB92-D2AD-48BD-96AE-101168E9C163@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-src-projects@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 17:19:02 -0000 --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2015 at 08:58:57AM -0800, Garrett Cooper wrote: > Please use atf_skip instead of atf_fail so the issues don't count > as failures. If you have bug numbers for the issues that would be nice > too in the error messages. To me, skipping tests is only done when the environment is not setup correctly for the test. Panics are a special case in that they cause an irreversible abort of the test run itself, and they *are* failures. We've adopted a practice of marking such tests as 'expected failure' and then preemptively failing them. Does that work for you? Bugs will come later if I don't have fixes I can commit. --=20 wca --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTKa3EACgkQF47idPgWcsVsPwCbB3kf7YmhE9bNmtqEJiX1HmuK 3roAoJeF8BRN/iI9REZX9XBQ8tJX8wdI =yc9Y -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--