From owner-cvs-all  Wed Apr 28 17: 1:44 1999
Delivered-To: cvs-all@freebsd.org
Received: from lor.watermarkgroup.com (lor.watermarkgroup.com [207.202.73.33])
	by hub.freebsd.org (Postfix) with ESMTP
	id 046CF15238; Wed, 28 Apr 1999 17:01:37 -0700 (PDT)
	(envelope-from luoqi@watermarkgroup.com)
Received: (from luoqi@localhost)
	by lor.watermarkgroup.com (8.8.8/8.8.8) id UAA09877;
	Wed, 28 Apr 1999 20:00:56 -0400 (EDT)
	(envelope-from luoqi)
Date: Wed, 28 Apr 1999 20:00:56 -0400 (EDT)
From: Luoqi Chen <luoqi@watermarkgroup.com>
Message-Id: <199904290000.UAA09877@lor.watermarkgroup.com>
To: bde@zeta.org.au, dfr@nlsystems.com, luoqi@watermarkgroup.com,
	tejblum@arc.hq.cti.ru
Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, dt@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

> It is (was?) actually done in locore.s just before calling init386().  I
> removed it to fix the (curproc != NULL) sanity checks in trap_pfault()
> (traps can happen when early when unmapped memory is accessed in ddb).
> 
I removed it from locore.s during yesterday's commit (and moved to init386).
It must have somehow come back after you removed it.

> I'll try setting curproc at the end of proc0_init() (it should not be set
> until after after proc0.p_stats has been initialised, in case hardclock()
> is called; hardclock() currently isn't called that early).
> 
Please use the macro SET_CURPROC() to set curproc, curproc is a non-lvalue
macro on i386 SMP.

> The comment about initialising curproc is now misplaced; previously it
> was backwards.
> 
> Bruce
> 
-lq


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message