From nobody Tue Jun 20 03:46:26 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QlXcd1nf4z4f7Mh for ; Tue, 20 Jun 2023 03:46:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QlXcd0BNfz3vnW for ; Tue, 20 Jun 2023 03:46:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-518b69d5b5dso5883177a12.1 for ; Mon, 19 Jun 2023 20:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1687232798; x=1689824798; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JTVNtK58LTY+3VEHKARTXCM7hc41+uL3lEcuNnQyjek=; b=wbW53yGkknJUBkqyJzIWjRP+yz34vvCcq5znUZMZ/ce/jnJRtG6RyxY4WJ+GVdh1js Z3a2W8eXiJB0nyAXMT6j/duun5Q6otQ7ejc16UX6sqqhZJ/H/VNXvuJpsxJfTG2ToVqS pLi4+VvlYUdhhjwFPAUHx29kwRxPIT9bBCJC6cRW/+vvTs8oY9QAnangdngr2FAxV7VU fsA2NE4VogcMsovnLEM+mxnv2KdpjmM/WXbdACdHD8PSJLcYwqVoFqsNoqK+ax8XXlIe XoLEwbd4aC6ES/efcHjIEIYL34ErLhH6DJPS+o+NqrAfFeyhbrzgPk4GtOCb46s+mZAa f3FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687232798; x=1689824798; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JTVNtK58LTY+3VEHKARTXCM7hc41+uL3lEcuNnQyjek=; b=P0aDkrXwyoaqi9PNAms+dI7Pk06Rw7ksgJmZSnfOWcRDgBdeP9q/Cg4Ipfp4Ol99Ur nYarAHYXRPC0qHKVF1v89umutUlY93LXcv8J1JQO/WFvdbMU/VGEycBSkBMS9K0PKTT5 KVjguvdWx5yMbUqgbTinVklpFWU15U7wPSN3iIixkXZtGO9D4waVDL/UI2JWBe7wT3sY yDxGIgxqQc+vSdSkXuOVBziU/ce+P3hyZ2HYvJVfrfMNiKFRLkzdA+YfGPpKWMa0aRTG 8zxiLwNBwX/k0oGB1bcqcxkdxQjTK6/lwG7z2t6SLWVtxvNB3uHTfRnvTzi2HNHVaAnL 5svQ== X-Gm-Message-State: AC+VfDyEQtKyigSxeMPb6geT5+MRsHfE4t69c+yKUo0fjbxjnkj98xwv 5mneLpqwYwJMIvoHFfZ9Q6iPpOZ7D8zXiOG1VtNCLQ== X-Google-Smtp-Source: ACHHUZ5JeGuTm5l99GzAMjg4Yz2NUNIpdnk1XKm5p9VpB8IgSXMjNBswpOgW1PJHm42T1mhT7zPWen0XEEtskrKzM98= X-Received: by 2002:a05:6402:10c4:b0:514:9e91:f54 with SMTP id p4-20020a05640210c400b005149e910f54mr7083906edu.26.1687232797617; Mon, 19 Jun 2023 20:46:37 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202306200023.35K0NSlA057479@gitrepo.freebsd.org> <60984493-01fd-d02d-496e-1c973cdda2f7@freebsd.org> In-Reply-To: <60984493-01fd-d02d-496e-1c973cdda2f7@freebsd.org> From: Warner Losh Date: Mon, 19 Jun 2023 21:46:26 -0600 Message-ID: Subject: Re: git: b908f6c45e02 - main - bsd.mkopt.mk: Add REQUIRED_OPTIONS list To: Colin Percival Cc: Ed Maste , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000008e42c305fe877f10" X-Rspamd-Queue-Id: 4QlXcd0BNfz3vnW X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000008e42c305fe877f10 Content-Type: text/plain; charset="UTF-8" On Mon, Jun 19, 2023, 9:14 PM Colin Percival wrote: > On 6/19/23 18:18, Warner Losh wrote: > > On Mon, Jun 19, 2023, 7:04 PM Ed Maste > > wrote: > > On Mon, 19 Jun 2023 at 20:23, Colin Percival > > wrote: > > > bsd.mkopt.mk : Add REQUIRED_OPTIONS list > > > > > > Options on this list will be forced to 'yes'. This is > intended for use > > > as a transitional measure when an option is ceasing to be > optional, > > > before all of the associated make logic is removed. > > > > Should we emit a warning when an option is disabled in src.conf but > > specified in REQUIRED_OPTIONS? > > > > e.g. warning: WITHOUT_CAPSICUM option ignored: it is no longer > supported > > > > I asked for this in the review... I didn't approve the review because I > was > > waiting for an answer to the request. > > I'm happy to add such a warning, although I'm not sure how useful it would > be > (unless we add a 'sleep 60' afterwards perhaps?), but I don't see any such > comments on the review... did phabricator eat it? > People will see it. No sleep needed. People read the logs. Maybe I was too subtle since we went down the does := work twice... Warner -- > Colin Percival > FreeBSD Deputy Release Engineer & EC2 platform maintainer > Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid > --0000000000008e42c305fe877f10 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jun 19, 2023, 9:14 PM Colin Percival <cpe= rciva@freebsd.org> wrote:
On= 6/19/23 18:18, Warner Losh wrote:
> On Mon, Jun 19, 2023, 7:04 PM Ed Maste <emaste@freebsd.o= rg
> <mailto:emaste@freebsd.org>> wrote:
>=C2=A0 =C2=A0 =C2=A0On Mon, 19 Jun 2023 at 20:23, Colin Percival <cperciva@freebsd.org
>=C2=A0 =C2=A0 =C2=A0<mailto:cperciva@freebsd.org>= ;> wrote:
>=C2=A0 =C2=A0 =C2=A0 > bsd.mkopt.mk <http://bsd.mkopt.mk>: Add REQUIRED_OPTIONS list
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Options on this list will = be forced to 'yes'.=C2=A0 This is intended for use
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0as a transitional measure = when an option is ceasing to be optional,
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0before all of the associat= ed make logic is removed.
>
>=C2=A0 =C2=A0 =C2=A0Should we emit a warning when an option is disabled= in src.conf but
>=C2=A0 =C2=A0 =C2=A0specified in REQUIRED_OPTIONS?
>
>=C2=A0 =C2=A0 =C2=A0e.g. warning: WITHOUT_CAPSICUM option ignored: it i= s no longer supported
>
> I asked for this in the review... I didn't approve the review beca= use I was
> waiting for an answer to the request.

I'm happy to add such a warning, although I'm not sure how useful i= t would be
(unless we add a 'sleep 60' afterwards perhaps?), but I don't s= ee any such
comments on the review... did phabricator eat it?

People will see it. No sle= ep needed. People read the logs.

Maybe I was too subtle since we went down the does :=3D work twic= e...

Warner=C2=A0
<= div dir=3D"auto">
--
Colin Percival
FreeBSD Deputy Release Engineer & EC2 platform maintainer
Founder, Tarsnap | www.tarsnap.com | Online backups = for the truly paranoid
--0000000000008e42c305fe877f10--