From owner-svn-src-all@FreeBSD.ORG Mon Oct 22 03:11:16 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2D996285 for ; Mon, 22 Oct 2012 03:11:16 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by mx1.freebsd.org (Postfix) with ESMTP id BCB0A8FC14 for ; Mon, 22 Oct 2012 03:11:15 +0000 (UTC) Received: by mail-ie0-f182.google.com with SMTP id k10so4039609iea.13 for ; Sun, 21 Oct 2012 20:11:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=K1mDPAchwjUE1giMbEguuDDU5ocLMdbQvHGpgQ+d3pY=; b=S7cjymyISblWit76W5KHwKGG5H4Hqi6C2ZNJGN0h7uNdtTYwXoaap9GSxZhHJXtfHr JPV2PffF3qyyeaNwZ9IoHCMMCtcHwJ7mYDtTypsG0bPxFOicMwMbx4Jw6s48YEMEB8C4 nubOGb74eJDIi009MdwWYI3LopasZEXVgRDflmPvVy+/EDv+rBkBMbc68y0bEnFgXJxs kSb/A8RBj9s8X5CrLEOt9sSAuwtnH7LQSaoqI/pUh1wTneR5m+hIOO6kKItcROV5XsrO V1Hgs0yd9tJoVu55iE45rOg4ZXEh03sMFVpeF4dzvbenYrgYC+0OJG47oJoEvHk2ce5y x91g== Received: by 10.50.41.132 with SMTP id f4mr7792524igl.39.1350875475344; Sun, 21 Oct 2012 20:11:15 -0700 (PDT) Received: from 63.imp.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPS id x5sm12472600igc.14.2012.10.21.20.11.10 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 21 Oct 2012 20:11:14 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r241757 - head/usr.sbin/pciconf Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <201210200830.26755.jhb@freebsd.org> Date: Sun, 21 Oct 2012 21:11:09 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <12563773-B5F9-4F48-A1A7-45E15296F9C4@bsdimp.com> References: <201210192248.q9JMmMpt093234@svn.freebsd.org> <201210200830.26755.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1084) X-Gm-Message-State: ALoCoQl7WjChJtsq0111tNlG9YvE+tnJ1EvASBJFCCHsS4wbWhnmowuD+sd/ls6SfLM0+d5Ijkjx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 03:11:16 -0000 On Oct 20, 2012, at 6:30 AM, John Baldwin wrote: > On Friday, October 19, 2012 06:48:22 PM Warner Losh wrote: >> Author: imp >> Date: Fri Oct 19 22:48:22 2012 >> New Revision: 241757 >> URL: http://svn.freebsd.org/changeset/base/241757 >>=20 >> Log: >> Indent ecaps the same way we indent caps. >=20 > This was on purpose so the '=3D' signs line up It makes it hard to parse otherwise... Perhaps the equal lining up = should be documented? Or at least be fixed to match everything else. = When ecaps were added the broke indentation... I'm happy to fix the alignment issue. Warner > . In fact, prior to this change,=20 > all of the equal signs line up: >=20 > igb0@pci0:8:0:0: class=3D0x020000 card=3D0x10a715d9 = chip=3D0x10a78086=20 > rev=3D0x02 hdr=3D0x00 > vendor =3D 'Intel Corporation' > device =3D '82575EB Gigabit Network Connection' > class =3D network > subclass =3D ethernet > bar [10] =3D type Memory, range 32, base 0xda020000, size 131072, = enabled > bar [14] =3D type Memory, range 32, base 0xda000000, size 131072, = enabled > bar [18] =3D type I/O Port, range 32, base 0x3000, size 32, = enabled > bar [1c] =3D type Memory, range 32, base 0xda080000, size 16384, = enabled > cap 01[40] =3D powerspec 2 supports D0 D3 current D0 > cap 05[50] =3D MSI supports 1 message, 64 bit=20 > cap 11[60] =3D MSI-X supports 10 messages in map 0x1c enabled > cap 10[a0] =3D PCI-Express 2 endpoint max data 128(256) link x4(x4) > ecap 0001[100] =3D AER 1 0 fatal 0 non-fatal 1 corrected > ecap 0003[140] =3D Serial 1 003048ffff5f9170 > PCI-e errors =3D Correctable Error Detected > Unsupported Request Detected > Corrected =3D Advisory Non-Fatal Error >=20 >=20 > --=20 > John Baldwin