From owner-dev-commits-src-all@freebsd.org Mon Feb 1 13:18:50 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8093C528E44; Mon, 1 Feb 2021 13:18:50 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DTpRt2zP5z3NRJ; Mon, 1 Feb 2021 13:18:50 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x335.google.com with SMTP id c127so13133609wmf.5; Mon, 01 Feb 2021 05:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pJ7oBfLV7TuEINkxTvap+YXzKPJqYwo9ROTd55JO/To=; b=HPQSczK4lbvTz0/tAQt61iU78VOP7EeJCClFKo5h/fYBcY5QRWcsYraecGC9rwzFHX /GiMh1DMChxPh2UgJXpO7+VGJF1BoenCFPw5b55BxDcQwT1TtFD+2Npg655v6YEuJkZC SYnJQloOTPdRNgOhKHydyPk0iTe7wFCh152z8ACXfqDdoNWzTjKDtnUQHzAekRe3hsGP /vDx3f6sQiDNPQu10n7hZvemAswrGPCTL2vT4OhL7onlRPn2iX+vMz9WVgZXbecizSe+ Abe7Vxi9sIE5J5LvrdJVcj6ApMtwPnfN1HT9MgvnqAbu/PgyD5cX1gtZHWz2c5/Ayytd uArA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pJ7oBfLV7TuEINkxTvap+YXzKPJqYwo9ROTd55JO/To=; b=a4FR8AyBdpf5+1q9mPQanV/gwwEuQ1zWSRgtdL/tqpFuNk6cB5ffrj6pK4EoiDnvDK ZSIEHXKanlCCTC35k6OWQEnPNY9FlJ8G7ZZrXl2C0Af9eIopTJuxwNY3QPipC7fu0wTD T1cdOY8Lx5ydsRrvuIJFGZmmlqkxnJak1zz0Gh2hLK1IKxpzZTqlT6obuRoH6uAwYYOo EXcMabg5fUFArHp9+Q0iQa81OBQGDvz4QVz5yqL1FTASTEzVq9OiuxmjeqY9AyAW2Gtx XhoMAWt9J6walZ4EGhrWLt3B6sypRA/Ii6A1fSi4iNObvXwzo+CgIrNwYejdoh/Mly2S wlOg== X-Gm-Message-State: AOAM532pli/bNoLwCfTwKc3FP0TbMVYsRjfMi1/17Ck57GY6aL0gc1dU 2jPIEMyk/2/wT5jXpNRS4vFcYKT0DecUlIRHq4A= X-Google-Smtp-Source: ABdhPJwYVloFm2c5P//4Cw2HLH0PWvY4gkuvLxxEiK5MtClnclUxVS0TITvrl3GYmgbUIqm1v0k/ZWHU7EbHFD/Bflw= X-Received: by 2002:a1c:98d4:: with SMTP id a203mr3454461wme.10.1612185528879; Mon, 01 Feb 2021 05:18:48 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:464c:0:0:0:0:0 with HTTP; Mon, 1 Feb 2021 05:18:47 -0800 (PST) In-Reply-To: <48fe9f24-e96b-1078-ada2-a8691ead6cf1@selasky.org> References: <202101281653.10SGrJWf002301@gitrepo.freebsd.org> <48fe9f24-e96b-1078-ada2-a8691ead6cf1@selasky.org> From: Mateusz Guzik Date: Mon, 1 Feb 2021 14:18:47 +0100 Message-ID: Subject: Re: git: 1a714ff20419 - main - This pulls over all the changes that are in the netflix tree that fix the ratelimit code. There were several bugs in tcp_ratelimit itself and we needed further work to support the multiple tag format coming for the joint TLS and Ratelimit dances. To: Hans Petter Selasky Cc: Michael Tuexen , Konstantin Belousov , Randall Stewart , Randall Stewart , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DTpRt2zP5z3NRJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2021 13:18:50 -0000 I cannot test the patch right now, but tinderbox builds for me with the offending commit reverted. On 2/1/21, Hans Petter Selasky wrote: > Hi, > > The attached patch should fix it. (Waiting for a quick review). But > there are more issues: > > For i386 I now see: > >> ld: error: undefined symbol: xdr_export_sec_context_res >>>>> referenced by gss_impl.c >>>>> gss_impl.o:(kgss_transfer_context) >> >> ld: error: undefined symbol: gssd_import_name_1 >>>>> referenced by gss_import_name.c >>>>> gss_import_name.o:(gss_import_name) >> >> ld: error: undefined symbol: gssd_pname_to_uid_1 >>>>> referenced by gss_pname_to_uid.c >>>>> gss_pname_to_uid.o:(gss_pname_to_uid) >>>>> referenced by gss_pname_to_uid.c >>>>> gss_pname_to_uid.o:(gss_pname_to_unix_cred) >> >> ld: error: undefined symbol: xdr_pname_to_uid_res >>>>> referenced by gss_pname_to_uid.c >>>>> gss_pname_to_uid.o:(gss_pname_to_unix_cred) >> >> ld: error: undefined symbol: gssd_release_cred_1 >>>>> referenced by gss_release_cred.c >>>>> gss_release_cred.o:(gss_release_cred) >> >> ld: error: undefined symbol: gssd_release_name_1 >>>>> referenced by gss_release_name.c >>>>> gss_release_name.o:(gss_release_name) >> > > Maybe xdr needs to be added to LINT now? > > Passing the ball onto Konstantin. > > --HPS > -- Mateusz Guzik