From owner-freebsd-current Wed Feb 11 11:51:14 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA04486 for current-outgoing; Wed, 11 Feb 1998 11:51:14 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA04472 for ; Wed, 11 Feb 1998 11:51:03 -0800 (PST) (envelope-from dyson@dyson.iquest.net) Received: (from root@localhost) by dyson.iquest.net (8.8.8/8.8.8) id OAA10458; Wed, 11 Feb 1998 14:50:51 -0500 (EST) (envelope-from dyson) Message-Id: <199802111950.OAA10458@dyson.iquest.net> Subject: Re: Possible BUG in vfs_bio.c/brelse() line 643 In-Reply-To: <199802111937.AA20502@iluvatar.unx.sas.com> from "John W. DeBoskey" at "Feb 11, 98 02:37:08 pm" To: jwd@unx.sas.com (John W. DeBoskey) Date: Wed, 11 Feb 1998 14:50:51 -0500 (EST) Cc: freebsd-current@FreeBSD.ORG From: "John S. Dyson" Reply-To: dyson@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG John W. DeBoskey said: > Hi, > > I believe the following is a bug in vfs_bio.c/brelse() version 1.147 > and the following change should be committed. > > 643c643 > < if (bp->b_flags && (B_INVAL | B_RELBUF)) > --- > > if (bp->b_flags & (B_INVAL | B_RELBUF)) > > I always did like those if (1) conditions. > > Comments? Critiques? > && in this case is very bad. I cannot make the change, but whomever has commit privs, and can do it right now, should change the && to &. -- John | Never try to teach a pig to sing, dyson@freebsd.org | it just makes you look stupid, jdyson@nc.com | and it irritates the pig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe current" in the body of the message