From owner-freebsd-current@FreeBSD.ORG  Thu Apr  1 19:59:52 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 921411065674
	for <freebsd-current@freebsd.org>; Thu,  1 Apr 2010 19:59:52 +0000 (UTC)
	(envelope-from tom@uffner.com)
Received: from eris.uffner.com (uffner.com [66.208.243.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E7948FC16
	for <freebsd-current@freebsd.org>; Thu,  1 Apr 2010 19:59:51 +0000 (UTC)
Received: from xiombarg.uffner.com
	(static-71-162-143-94.phlapa.fios.verizon.net [71.162.143.94])
	(authenticated bits=0)
	by eris.uffner.com (8.14.3/8.14.3) with ESMTP id o31K2C6V043037
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256
	verify=FAIL); Thu, 1 Apr 2010 16:02:13 -0400 (EDT)
	(envelope-from tom@uffner.com)
Message-ID: <4BB4FB35.2040703@uffner.com>
Date: Thu, 01 Apr 2010 15:59:49 -0400
From: Tom Uffner <tom@uffner.com>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.1.8) Gecko/20100330 SeaMonkey/2.0.3
MIME-Version: 1.0
To: Xin LI <delphij@gmail.com>
References: <4BA7E0B8.3080406@delphij.net>	
	<4BAE2B4F.6060005@protected-networks.net>	
	<4BB3FD5D.9070600@uffner.com>
	<r2oa78074951003312051kca872e0el511273674bd9e4b@mail.gmail.com>
In-Reply-To: <r2oa78074951003312051kca872e0el511273674bd9e4b@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
Subject: Re: HEADSUP: zlib updated [svn commit: r205471 - in head: . lib/libz
 lib/libz/contrib lib/libz/doc sys/sys]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2010 19:59:52 -0000

Xin LI wrote:
> On Wed, Mar 31, 2010 at 6:56 PM, Tom Uffner<tom@uffner.com>  wrote:
>> Michael Butler wrote:
>>
>>> This breaks most (if not all) of the QT4-dependent ports for the lack of
>>> a definition of "off64_t".
>>
>> it also breaks multimedia/mplayer, graphics/ImageMagick, and
>> print/ghostscript8 & everything that depends on it.
>
> Just because they used to compile DOES NOT mean they were right.  It's
> NOT right to define _LARGEFILE64_SOURCE on FreeBSD, see:
>
> http://www.delorie.com/gnu/docs/glibc/libc_13.html

i realize this. i was just adding to the list of ports that no longer
build after this change. ghostscript is kind of important for print
support.

i doubt this is "right" either, but it is a quick & dirty way to
make mplayer compile again:

--- configure.orig      2010-04-01 15:49:37.000000000 -0400
+++ configure   2010-04-01 15:50:50.000000000 -0400
@@ -5337,7 +5337,7 @@
  #include <dvdread/nav_read.h>
  int main(void) { return 0; }
  EOF
-    cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE \
+    cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 \
        -ldvdread $_ld_dl && _dvdread=yes && _res_comment="external"
    fi
  fi
@@ -7412,8 +7412,6 @@
  if test "$_largefiles" = yes || freebsd ; then
    CFLAGS="$CFLAGS -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64"
    if test "$_dvdread" = yes || test "$_libdvdcss_internal" = yes ; then
-    # dvdread support requires this (for off64_t)
-    CFLAGS="$CFLAGS -D_LARGEFILE64_SOURCE"
      cygwin && CFLAGS="$CFLAGS -DSYS_CYGWIN"
    fi
  fi