Date: Fri, 13 Apr 2018 11:56:51 +0000 (UTC) From: Adriaan de Groot <adridg@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r467236 - in head/devel/qtcreator: . files Message-ID: <201804131156.w3DBupRp094832@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adridg Date: Fri Apr 13 11:56:50 2018 New Revision: 467236 URL: https://svnweb.freebsd.org/changeset/ports/467236 Log: Massage devel/qtcreator to not crash on opening files. The patch describes itself as a hack. It is. PR: 226224 Reported by: jt@ixsystems.com Approved by: tcberner (mentor, implicit) Added: head/devel/qtcreator/files/ head/devel/qtcreator/files/patch-src_libs_qmljs_qmljscontext.cpp (contents, props changed) Modified: head/devel/qtcreator/Makefile Modified: head/devel/qtcreator/Makefile ============================================================================== --- head/devel/qtcreator/Makefile Fri Apr 13 11:44:09 2018 (r467235) +++ head/devel/qtcreator/Makefile Fri Apr 13 11:56:50 2018 (r467236) @@ -3,6 +3,7 @@ PORTNAME= qtcreator DISTVERSION= 4.5.1 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= QT/official_releases/qtcreator/${DISTVERSION:R}/${DISTVERSION} DISTNAME= qt-creator-opensource-src-${DISTVERSION} Added: head/devel/qtcreator/files/patch-src_libs_qmljs_qmljscontext.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/qtcreator/files/patch-src_libs_qmljs_qmljscontext.cpp Fri Apr 13 11:56:50 2018 (r467236) @@ -0,0 +1,16 @@ +This is just a hack, but the upstream response was "FreeBSD, whatevs". +In default ports builds Without this spurious qDebug(), the pointer +*reference gets weird addresses which don't correspond to any object +allocated by the program. This hack may be disguising a memory problem +higher up in the application. + +--- src/libs/qmljs/qmljscontext.cpp.orig 2018-02-07 14:23:39 UTC ++++ src/libs/qmljs/qmljscontext.cpp +@@ -175,6 +175,7 @@ ReferenceContext::ReferenceContext(const + const Value *ReferenceContext::lookupReference(const Value *value) + { + const Reference *reference = value_cast<Reference>(value); ++ qDebug(); // some form of synchronisation happens here, preventing a crash + if (!reference) + return value; +
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804131156.w3DBupRp094832>