From owner-svn-ports-all@freebsd.org Sun Mar 22 22:47:55 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D71DC26FE86; Sun, 22 Mar 2020 22:47:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48lt2M3Tr9z4YnT; Sun, 22 Mar 2020 22:47:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6888514A3C; Sun, 22 Mar 2020 22:47:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f42.google.com with SMTP id m2so6240115qvu.13; Sun, 22 Mar 2020 15:47:55 -0700 (PDT) X-Gm-Message-State: ANhLgQ0oHnXqSuq565tvIDKWN2YRN3T3fSVXhDgzZREYS3Yf+xhpl/Xj W5bUPvQERD7YoC89qY9t1n+FyFRD6cLriz5aW88= X-Google-Smtp-Source: ADFU+vvDz5BgyK5Bmkg26DahVGHbJ+usQUavfse/VurpxClcJcwgM8BAW82g5SSlQJfz++/7ZxIQqfsvUmu52nt/NcQ= X-Received: by 2002:ad4:4ba5:: with SMTP id i5mr4368070qvw.181.1584917274947; Sun, 22 Mar 2020 15:47:54 -0700 (PDT) MIME-Version: 1.0 References: <202003120041.02C0fXkP049507@repo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Sun, 22 Mar 2020 17:47:43 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r528258 - in head/emulators/virtualbox-ose: . files To: Gerald Pfeifer Cc: Baptiste Daroussin , Kubilay Kocak , vbox@freebsd.org, ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 22:47:55 -0000 On Sun, Mar 22, 2020 at 5:40 PM Gerald Pfeifer wrote: > > On Thu, 12 Mar 2020, Kyle Evans wrote: > > Log: > > emulators/virtualbox-ose: use contemporary GCC instead of old llvm > > This patch does not exactly do that. =:o > > > +# machine/atomic.h may use features that are only available in GCC9. This is > > +# a workaround, anyways- we should be expressing USES= compiler:c++14-lang, but > > +# contemporary clang miscompiles virtualbox in some fashion and yields runtime > > +# breakage. > > +USE_GCC= any > > USE_GCC=any allows using the age old, rotten, GCC 4.2 based system > compiler where still present. > > This is practically not the case with ONLY_FOR_ARCHS= i386 amd64 which > this port also specifies, but that is a subtle and indirect approach. > > (Where there is no /usr/bin/gcc USE_GCC=any degenerates to USE_GCC=yes, > so the two are practically equivalent here, but still the USE_GCC=yes > form is the one requiring a current version.) > > Okay to change this to USE_GCC=yes? > It's actually needing to be changed back away from GCC, because this inherently breaks as the qt bits it uses are compiled with llvm and used an incompatible libc++ -- there's an open PR about it after this commit, I'm trying to work out where newer clang is failing to compile properly. =-( > Gerald > > PS: How do patches to this port actually get approved? The log has > hardly any Approved by-s. I seem to recall the situation is that there's now an effectively one-man vbox@ team, and this seems to be mostly on life-support. There is a long-standing PR to push virtualbox-ose to 6.x, but I don't recall if that was being ushered through by vbox@ or not.