From owner-dev-commits-ports-main@freebsd.org Fri Sep 3 14:54:48 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2426E677072 for ; Fri, 3 Sep 2021 14:54:48 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H1LRr0DfXz4Vv9 for ; Fri, 3 Sep 2021 14:54:48 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id D9D3520232 for ; Fri, 3 Sep 2021 14:54:47 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f48.google.com with SMTP id lc21so12621016ejc.7 for ; Fri, 03 Sep 2021 07:54:47 -0700 (PDT) X-Gm-Message-State: AOAM533jZ8BhDg1sRRgAX2BLFW5JjoACssqIvZnOHGtUz+x3P1WqihRq gAEobLLz8hYA2KC6fOyqopHFBs1HrDLV4oRdWiVwNw== X-Google-Smtp-Source: ABdhPJyKHHiAh/Wz1xLJig41J+uh3m2USApgZbeSnkOEG43o7LdAZeAWp5jDFj896zY0HubbdHfPyNc37DY6EM8VF8s= X-Received: by 2002:a17:906:f11:: with SMTP id z17mr4700323eji.385.1630680886689; Fri, 03 Sep 2021 07:54:46 -0700 (PDT) MIME-Version: 1.0 References: <202109031443.183Ehh3T001527@gitrepo.freebsd.org> In-Reply-To: <202109031443.183Ehh3T001527@gitrepo.freebsd.org> From: Po-Chuan Hsieh Date: Fri, 3 Sep 2021 22:54:10 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 778fa2dc6685 - main - security/nss: Add TODO about ca_root_nss PORTREVISION To: Matthias Andree Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 14:54:48 -0000 On Fri, Sep 3, 2021 at 10:43 PM Matthias Andree wrote: > The branch main has been updated by mandree: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=778fa2dc6685d70615ff113f0fe8c9183e4a84bf > > commit 778fa2dc6685d70615ff113f0fe8c9183e4a84bf > Author: Matthias Andree > AuthorDate: 2021-09-03 14:41:40 +0000 > Commit: Matthias Andree > CommitDate: 2021-09-03 14:43:34 +0000 > > security/nss: Add TODO about ca_root_nss PORTREVISION > > Since ca_root_nss inherit's nss's PORTVERSION, add a comment > to remind maintainers to reset ca_root_nss's PORTREVISION next time > that nss's PORTVERSION gets bumped. > This is incorrect. security/ca_root_nss uses VERSION_NSS from its own Makefile (around line 30). e.g. https://cgit.freebsd.org/ports/commit/security/ca_root_nss/Makefile?id=7ef74aa064355c0c3c5f24b2a3579eb80dabb965 > Approved by: portmgr@ (blanket, comment-only change) > --- > security/nss/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/nss/Makefile b/security/nss/Makefile > index e4e747fb893c..cb9eb47763b9 100644 > --- a/security/nss/Makefile > +++ b/security/nss/Makefile > @@ -1,7 +1,7 @@ > # Created by: Maxim Sobolev > > PORTNAME= nss > -PORTVERSION= 3.69 > +PORTVERSION= 3.69 # when bumping this, please reset PORTREVISION in > ../ca_root_nss/Makefile > CATEGORIES= security > MASTER_SITES= > MOZILLA/security/${PORTNAME}/releases/${DISTNAME:tu:C/[-.]/_/g}_RTM/src > >