From owner-svn-src-all@freebsd.org Fri May 13 18:46:21 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDA64B3A7E2; Fri, 13 May 2016 18:46:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF3131A1E; Fri, 13 May 2016 18:46:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 60074B95B; Fri, 13 May 2016 14:46:20 -0400 (EDT) From: John Baldwin To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299653 - head/sys/compat/linuxkpi/common/include/linux Date: Fri, 13 May 2016 11:43:59 -0700 Message-ID: <1651080.VgjHNWYnll@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201605131010.u4DAAioY094617@repo.freebsd.org> References: <201605131010.u4DAAioY094617@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 13 May 2016 14:46:20 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 18:46:22 -0000 On Friday, May 13, 2016 10:10:44 AM Hans Petter Selasky wrote: > @@ -190,6 +258,7 @@ > #define smp_processor_id() PCPU_GET(cpuid) > #define num_possible_cpus() mp_ncpus > #define num_online_cpus() mp_ncpus > +#define cpu_has_clflush (1) This is only true on amd64. More accurate would be: #ifdef __amd64__ #define cpu_has_clflush (1) #elif defined(__i386__) #define cpu_has_clflush (cpu_feature & CPUID_CLFSH) #else #define cpu_has_clflush clflush_not_supported #endif Presumably you aren't planning to restrict all of OFED and drm2 to only be used on amd64? -- John Baldwin