From owner-freebsd-bugs@FreeBSD.ORG Sun May 22 20:40:07 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C6E016A41C for ; Sun, 22 May 2005 20:40:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A471643D48 for ; Sun, 22 May 2005 20:40:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4MKe6fd050656 for ; Sun, 22 May 2005 20:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4MKe6YV050655; Sun, 22 May 2005 20:40:06 GMT (envelope-from gnats) Resent-Date: Sun, 22 May 2005 20:40:06 GMT Resent-Message-Id: <200505222040.j4MKe6YV050655@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Wojciech A. Koszek" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CC4F16A41C for ; Sun, 22 May 2005 20:35:37 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (silver.iplus.pl [80.48.250.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73DC643D1D for ; Sun, 22 May 2005 20:35:35 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4]) by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id j4MKkWLh050104 for ; Sun, 22 May 2005 20:46:32 GMT (envelope-from dunstan@freebsd.czest.pl) Received: (from dunstan@localhost) by freebsd.czest.pl (8.12.10/8.12.9/Submit) id j4MKkVxg050103; Sun, 22 May 2005 20:46:31 GMT (envelope-from dunstan) Message-Id: <200505222046.j4MKkVxg050103@freebsd.czest.pl> Date: Sun, 22 May 2005 20:46:31 GMT From: "Wojciech A. Koszek" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/81371: [PATCH] ng_socket: 2nd "int error" hides real error code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Wojciech A. Koszek" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 May 2005 20:40:07 -0000 >Number: 81371 >Category: kern >Synopsis: [PATCH] ng_socket: 2nd "int error" hides real error code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 22 20:40:06 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Wojciech A. Koszek >Release: FreeBSD 5.4-STABLE i386 >Organization: >Environment: System: FreeBSD dunstan.freebsd.czest.pl 5.4-STABLE FreeBSD 5.4-STABLE #5: Sun May 8 11:57:11 CEST 2005 dunstan@dunstan.freebsd.czest.pl:/usr/obj/usr/src/sys/HOME8 i386 >Description: There is a redundant declaration ("int error") in sys/netgraph/ng_socket.c. 'error' is declared in ngc_send() and initialized with zero. Second 'error' is declared in block responsible for loading needed Netgraph modules. If module does not exist (linker_load_module()), 'error' in block's scope is equal to 2, but 'error' in function's scope is returned while it's value is not changed (still equal to zero). >How-To-Repeat: root@dunstan:(/)# ls /boot/kernel/ng_device.ko ls: /boot/kernel/ng_device.ko: No such file or directory root@dunstan:(/)# ngctl [..] + mkpeer . device d d + list There are 1 total nodes: Name: ngctl1040 Type: socket ID: 00000001 Num hooks: 0 >Fix: Patch [diff.0.ng_socket.c] removes second declaration of error. --- diff.0.ng_socket.c begins here --- Index: src/sys/netgraph/ng_socket.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_socket.c,v retrieving revision 1.64 diff -r1.64 ng_socket.c 286d285 < int error; --- diff.0.ng_socket.c ends here --- >Release-Note: >Audit-Trail: >Unformatted: