From owner-freebsd-rc@FreeBSD.ORG  Mon Jan  9 10:22:40 2012
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5064C1065670;
	Mon,  9 Jan 2012 10:22:40 +0000 (UTC)
	(envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60])
	by mx1.freebsd.org (Postfix) with ESMTP id F3EC38FC14;
	Mon,  9 Jan 2012 10:22:39 +0000 (UTC)
Received: from localhost (58.wheelsystems.com [83.12.187.58])
	by mail.dawidek.net (Postfix) with ESMTPSA id 6F6767B1;
	Mon,  9 Jan 2012 11:22:38 +0100 (CET)
Date: Mon, 9 Jan 2012 11:21:30 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Stefan Esser <se@freebsd.org>
Message-ID: <20120109102129.GA4117@garage.freebsd.pl>
References: <4F079A76.3030306@FreeBSD.org>
	<20120107112538.GC1696@garage.freebsd.pl>
	<4F08C95F.6040808@FreeBSD.org>
	<20120108.081216.1547061187942402256.hrs@allbsd.org>
	<4F0A22D8.8090206@FreeBSD.org> <4F0AB60E.7090601@freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="n8g4imXOkfNTN/H1"
Content-Disposition: inline
In-Reply-To: <4F0AB60E.7090601@freebsd.org>
X-OS: FreeBSD 9.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Doug Barton <dougb@FreeBSD.org>, freebsd-rc@FreeBSD.org,
	Hiroki Sato <hrs@FreeBSD.org>
Subject: Re: Making use of set_rcvar.
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2012 10:22:40 -0000


--n8g4imXOkfNTN/H1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 09, 2012 at 10:40:30AM +0100, Stefan Esser wrote:
> Am 09.01.2012 00:12, schrieb Doug Barton:
> > Attached is a patch that does what I suggested a long time ago, removes
> > set_rcvar() entirely and assigns each rcvar statically. I'll commit this
> > in a few days if no one objects. (Note, it can't be committed yet
> > because the scripts in ports that call set_rcvar() have to be modified
> > first.)
> [...]
> > Index: rc.d/nscd
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- rc.d/nscd	(revision 229825)
> > +++ rc.d/nscd	(working copy)
> > @@ -19,7 +19,7 @@
> >  . /etc/rc.subr
> >
> >  name=3D"nscd"
> > -rcvar=3D`set_rcvar`
> > +rcvar=3D"nscd_enable"
>=20
> Why not generally use
>=20
> 	rcvar=3D"${name}_enable"
>=20
> instead of (e.g.)
>=20
> 	rcvar=3D"nscd_enable"
>=20
> in all scripts *in your patch set*, for which the outcome is the same?

I fully agree. There is one less thing to change after reusing a script.
I can't see how this might be a bad idea, really.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com

--n8g4imXOkfNTN/H1
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAk8Kv6kACgkQForvXbEpPzTQPQCfSnhWRRriWKFaUFZA4OiOFsHZ
R/YAniGIUcT3szuviGkXAQa/qa8w02cn
=7oDI
-----END PGP SIGNATURE-----

--n8g4imXOkfNTN/H1--