From owner-freebsd-bugs Thu Jan 27 12:30:11 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 0D43015645 for ; Thu, 27 Jan 2000 12:30:10 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id MAA65566; Thu, 27 Jan 2000 12:30:04 -0800 (PST) (envelope-from gnats@FreeBSD.org) Date: Thu, 27 Jan 2000 12:30:04 -0800 (PST) Message-Id: <200001272030.MAA65566@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Peter Jeremy Subject: Re: bin/5604: setenv(3) function has memory leak, other bugs Reply-To: Peter Jeremy Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/5604; it has been noted by GNATS. From: Peter Jeremy To: Ruslan Ermilov , Bruce Evans Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/5604: setenv(3) function has memory leak, other bugs Date: Fri, 28 Jan 2000 07:20:32 +1100 On 2000-Jan-27 20:17:39 +1100, Ruslan Ermilov wrote: >While we are on this topic, how about the following patch to setenv.c? Seems good. (And I notice you've committed it). >Any objections if I close PR 10341 as a duplicate of PR 5604? I previously told Archie that I'd be satisfied with documenting the bug as a fix. From a different perspective, since we've fixed the first half of PR5604, but not touched the second half - which is what PR10341 covers, we might have been better off closing 5604 and leaving 10341 to remind us of the real problem :-/. On Thu, 27 Jan 2000 22:10:13 +1100, Bruce Evans wrote: >PR 10341 has the only example that I know of where the memory leak >matters, but we all know this now :-). I agree that example was contrived. The problem _did_ bite me though - I was doing some exhaustive testing on a function that did time conversions in multiple timezones, and the ctime(3) functions don't have any way to specify a timezone other than via $TZ, so I was continually calling putenv(3) and wondered about the process bloat (10341) and poor performance (10342). Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message