Date: Tue, 24 Nov 2009 02:35:18 +0300 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/140811: [patch] sysutils/zfs-snapshot-mgmt: don't barf on top-level dataset Message-ID: <86ljhw3jd5.fsf@gmail.com> Resent-Message-ID: <200911232340.nANNe23X059008@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 140811
>Category: ports
>Synopsis: [patch] sysutils/zfs-snapshot-mgmt: don't barf on top-level dataset
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 23 23:40:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD 9.0-CURRENT #0 199718M: Tue Nov 23 19:34:20 UTC 2009 holo@raphael.local:/a/objdir/a/dirty_build/sys/PHOENIX amd64
>Description:
>How-To-Repeat:
$ zfs list -Ho name
tank
tank/home
tank/var
%% zfs-snapshot-mgmt.conf
snapshot_prefix: auto-
filesystems:
tank:
creation_rule:
at_multiple: 10
offset: 0
preservation_rules:
- { for_minutes: 90, at_multiple: 0, offset: 0 }
- { for_minutes: 720, at_multiple: 30, offset: 0 }
- { for_minutes: 10080, at_multiple: 180, offset: 120 }
%%
# zfs-snapshot-mgmt
/usr/local/bin/zfs-snapshot-mgmt:157:in `pool': private method `chop' called for nil:NilClass (NoMethodError)
from /usr/local/bin/zfs-snapshot-mgmt:186:in `initialize'
from /usr/local/bin/zfs-snapshot-mgmt:186:in `map'
from /usr/local/bin/zfs-snapshot-mgmt:186:in `initialize'
from /usr/local/bin/zfs-snapshot-mgmt:199:in `new'
from /usr/local/bin/zfs-snapshot-mgmt:199
>Fix:
--- poolname_crop.diff begins here ---
Index: sysutils/zfs-snapshot-mgmt/files/patch-zfs-snapshot-mgmt
===================================================================
RCS file: sysutils/zfs-snapshot-mgmt/files/patch-zfs-snapshot-mgmt
diff -N sysutils/zfs-snapshot-mgmt/files/patch-zfs-snapshot-mgmt
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ sysutils/zfs-snapshot-mgmt/files/patch-zfs-snapshot-mgmt 23 Nov 2009 23:10:51 -0000
@@ -0,0 +1,14 @@
+--- zfs-snapshot-mgmt~
++++ zfs-snapshot-mgmt
+@@ -154,7 +154,11 @@ class FSInfo
+ end
+
+ def pool
++ if name["/"]
+ name[/\A.*?\//].chop
++ else
++ name
++ end
+ end
+
+ private
--- poolname_crop.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ljhw3jd5.fsf>