From owner-svn-src-all@freebsd.org Sat Feb 11 09:12:39 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0FB7CD92DA for ; Sat, 11 Feb 2017 09:12:39 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x234.google.com (mail-yw0-x234.google.com [IPv6:2607:f8b0:4002:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69E331ECF for ; Sat, 11 Feb 2017 09:12:39 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x234.google.com with SMTP id v200so32805599ywc.3 for ; Sat, 11 Feb 2017 01:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4J2QlmLzazBmZcxVLkQQorgHoGK8tv8Oq5lflTYEGRU=; b=DI08FbVJ6xWSkJwOgACMSe6WYH2/CtJGhKqg1swEbE7mIII7Lp2h2eAfy0+fCITOtx fzarB0SK7vnq3MwiCIWAnuEjVY4g6HeDA1L6adoraAHfNBjQ7wdSnxchl8BaDbc3ZNk/ CZY8NGVXN6hyUPdHerwnL9l21eo+JnlQhE4GhLg5VMukXMydZ2vMbC11OvtJGh/wr4kC 6dqxkgKyI6eRfKqOBHuY5SawVNU+gdXCj8XsykeqwfbHO0pJv9v+RwJ3k48S13nsJtAh PmZAgzlaCdihQjnEpTAALqcoQ22lZzf2j7UnIffFbXKpmqWkKd+Zn9FEmXeQRSxVWC2u es9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4J2QlmLzazBmZcxVLkQQorgHoGK8tv8Oq5lflTYEGRU=; b=tcdzYSy2RdU0VuUw1n9mc5Vy/UQ4+AJk8cV9gNdojHoKYL7OqIiM1zTm0xEDGoLv9U 29qmXbWHPDEwsmOzBrUDaGiFJ6g4vTQc/ocdecmWg5hSYJB/REIXw4i11bzasHgbtips vUGZrdIPMYfDar6by5w2EMZFjBx0tYq5yT6PKsIgFVi9cbHTBF40T5/Et41ZQtw3ieoK GpmuVbXkI7+fL0JbWMvMk2lPXWSHq41+zBM/GvE2WIUYJRYczsmqvMXdkVz0GZUJlwXT ochTMNjaU/g7EFDMHaphn4pSZfel8BN6+Nj8ZytJmudSY7HNEBKg0iH+GyPdSjyrYEV5 z9nA== X-Gm-Message-State: AMke39mKWWmYHgxuOrUBJQoNZ/z2vQ8rWTDNai0hoIYudWNfV7AtZIkdXZVoekHp9+4R0q1m/hN6nAjvHC9cOA== X-Received: by 10.129.110.133 with SMTP id j127mr9442105ywc.214.1486804358278; Sat, 11 Feb 2017 01:12:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.52.76 with HTTP; Sat, 11 Feb 2017 01:12:07 -0800 (PST) In-Reply-To: <201702110735.v1B7ZROH028648@repo.freebsd.org> References: <201702110735.v1B7ZROH028648@repo.freebsd.org> From: Ed Schouten Date: Sat, 11 Feb 2017 10:12:07 +0100 Message-ID: Subject: Re: svn commit: r313632 - in stable/10/contrib/netbsd-tests/lib/libc/gen: . posix_spawn To: Ngie Cooper Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Feb 2017 09:12:39 -0000 2017-02-11 8:35 GMT+01:00 Ngie Cooper : > Note that sys/types.h is required on FreeBSD for kqueue(2), unlike NetBSD Which is a bug on its own in my opinion. What do you think of this patch? Index: sys/sys/event.h =================================================================== --- sys/sys/event.h (revision 313335) +++ sys/sys/event.h (working copy) @@ -29,7 +29,8 @@ #ifndef _SYS_EVENT_H_ #define _SYS_EVENT_H_ -#include +#include +#include #define EVFILT_READ (-1) #define EVFILT_WRITE (-2) @@ -57,11 +58,11 @@ } while(0) struct kevent { - uintptr_t ident; /* identifier for this event */ + __uintptr_t ident; /* identifier for this event */ short filter; /* filter for event */ - u_short flags; - u_int fflags; - intptr_t data; + unsigned short flags; + unsigned int fflags; + __intptr_t data; void *udata; /* opaque user data identifier */ }; -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717