From nobody Tue Jun 16 11:23:06 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gfl3H0D0zz6hSwG for ; Tue, 16 Jun 2026 11:23:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gfl3G42Pxz3MJx for ; Tue, 16 Jun 2026 11:23:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781608986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lnhF5qHA7kefsz/Td6TAss/okivN0G7+Tg1rdJmIWR8=; b=ANbJ4883Z7WV+Dd/LfV9hVzgFN1WYVFAWYUactoIkYoLPWDuellDDs/0m4Ygc376Pv6Tg0 OmmEAn2PDgF6/2+3JXGVkVuUXQKstQHgl8it3V6i9Whvpkkwl/Q4d+C9+DaXTkm+7rA6AT 78W+vMfsNljmGl4VqcRLXg7BlBXTXBJh4oReRfVEpD1gVW6BNwXhyQoAYeNsodkh0TlNFy 8luWCn7jWNju32T456tzi5JOwi42tO+2Nkj2tS2g+niVhUcLOR3i7nYo9sTtg96T3PygCr NZTlHME7eidftKvlsiNxTpDfxxR9bheU5AaC+zDL72dixmR7a0sZpJdP/F2XGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781608986; a=rsa-sha256; cv=none; b=W+SHuSAHbXFsqjQhe8HgSPPMHLP+XIRr5Z4NB7iOLZ9ZJw7WQ9x0CcVwdQ9ZMBurXXLIr/ drl7wcQP5nhlo2U0cg0dVZq6qPjVUj2F6S5Mgnu0ZDhl8HN/h0iPp5cFAvGaSP3z9MoFho jzIgE9hMaep/PPO//Y1cEYQTOJunGKCw3EB2+iXFJI5MMicek+X40yaolid0sd9hGpoJns htQ8EoQL/35lJFRGKGEaP1SMYJ3Bd9keNOCi1NILPu04Dr/IncH1YveChKpBRdr09pM47Z Fk4y0dqAY/dJNjNCh3S784AYT1KHoMnfl6MuVJQf8ed4qN4YQbo8N7kO1BNlkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781608986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lnhF5qHA7kefsz/Td6TAss/okivN0G7+Tg1rdJmIWR8=; b=byxTtbE2oGvfl/L0YzPmvKivsn7KKKLMoMoMkxYi4j+zDLoA4w097uh77YGnG5CdEvJduV XrCCXcSW3zFBN7nuId1KuVPaNNWqOdTFxf2wzU0dKZTxxXN2+fL9hQRQkTaA+ERNM8v0Yq IepKVnxwYEGOsmz2tqxu1QPiZlCHhBSs1i7LwKGchdZ17P6BrVlQKxRBnLObpxPi3mLlrN fCpdSEC2L+qjcvvcl5HSViwJCAYzPdix9YkMkN9i8Q1DGFwAy3q6/NWJXeajxnbC/9ddxh U1QNrdBGAg+QZGJmvveA5v4KSptA/pV76GY9z3jQCUERjFun66tVgJTkD7/ipw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gfl3G3bYXz8Fp for ; Tue, 16 Jun 2026 11:23:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e7a6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 16 Jun 2026 11:23:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Baptiste Daroussin Subject: git: 3b6f833c95eb - main - uvideo: increase isochronous transfer depth for throughput List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3b6f833c95eb65b29a9f506928467236a11d5169 Auto-Submitted: auto-generated Date: Tue, 16 Jun 2026 11:23:06 +0000 Message-Id: <6a31321a.1e7a6.2fe02931@gitrepo.freebsd.org> The branch main has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=3b6f833c95eb65b29a9f506928467236a11d5169 commit 3b6f833c95eb65b29a9f506928467236a11d5169 Author: Baptiste Daroussin AuthorDate: 2026-05-18 21:44:27 +0000 Commit: Baptiste Daroussin CommitDate: 2026-06-16 11:21:05 +0000 uvideo: increase isochronous transfer depth for throughput Increase NFRAMES_MAX from 40 to 128 and IXFERS from 3 to 5 to keep more packets in flight on the USB bus. This brings throughput from ~13.5 MB/s to ~21 MB/s (for comparison on the same camera webcamd provided ~20MB/s. The linux driver also uses 5 IXFERS (but only 32 NFRAMES_MAX) Tested by: manu --- sys/dev/usb/video/uvideo.c | 20 ++++++++++++++++++++ sys/dev/usb/video/uvideo.h | 4 ++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/sys/dev/usb/video/uvideo.c b/sys/dev/usb/video/uvideo.c index b35561ff6a24..9229aa34fc47 100644 --- a/sys/dev/usb/video/uvideo.c +++ b/sys/dev/usb/video/uvideo.c @@ -196,6 +196,8 @@ enum { UVIDEO_ISOC_RX_0, UVIDEO_ISOC_RX_1, UVIDEO_ISOC_RX_2, + UVIDEO_ISOC_RX_3, + UVIDEO_ISOC_RX_4, UVIDEO_BULK_RX, UVIDEO_N_XFER }; @@ -616,6 +618,24 @@ static const struct usb_config uvideo_isoc_config[UVIDEO_IXFERS] = { .flags = {.short_xfer_ok = 1, .short_frames_ok = 1,}, .callback = &uvideo_isoc_callback, }, + [3] = { + .type = UE_ISOCHRONOUS, + .endpoint = UE_ADDR_ANY, + .direction = UE_DIR_IN, + .bufsize = 0, + .frames = UVIDEO_NFRAMES_MAX, + .flags = {.short_xfer_ok = 1, .short_frames_ok = 1,}, + .callback = &uvideo_isoc_callback, + }, + [4] = { + .type = UE_ISOCHRONOUS, + .endpoint = UE_ADDR_ANY, + .direction = UE_DIR_IN, + .bufsize = 0, + .frames = UVIDEO_NFRAMES_MAX, + .flags = {.short_xfer_ok = 1, .short_frames_ok = 1,}, + .callback = &uvideo_isoc_callback, + }, }; static const struct usb_config uvideo_bulk_config[1] = { diff --git a/sys/dev/usb/video/uvideo.h b/sys/dev/usb/video/uvideo.h index fc811c5d65fa..9f8570aaf7ed 100644 --- a/sys/dev/usb/video/uvideo.h +++ b/sys/dev/usb/video/uvideo.h @@ -640,9 +640,9 @@ struct usb_video_format_desc { /* * Driver specific private definitions. */ -#define UVIDEO_NFRAMES_MAX 40 +#define UVIDEO_NFRAMES_MAX 128 -#define UVIDEO_IXFERS 3 +#define UVIDEO_IXFERS 5 struct uvideo_vs_iface { uint8_t iface_index; int numalts;