From nobody Sun Sep 21 19:17:15 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cVGG63yB0z67qS7; Sun, 21 Sep 2025 19:17:18 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cVGG637m0z3QXP; Sun, 21 Sep 2025 19:17:18 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758482238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FxTThHbm7EyHQrZOIpcyAnh33A8o30JEiV4sxPXkFus=; b=Bm5tJex59J8NllNxECjn8MJnnj+m0eRHQLvEGi/vsoVsuPdA4GqqzdbSHz53tFBxGCXCaV WjN6UBKQKz/V5q2NV1jqf5qvtYSf3ksHLZANmCHiUqvWuvNfH03wRKd+THB7yoBZ1prcF3 DsXW9DiO98gZgi6g+F4HO4zYtLE3ryL6SvT/l3wq3fYwtTjr299RCIoRqE/PyDdiRwe3bX /ranBA+KXB3/9fDBw2hpsM4X8gN35/eXTybrf2QGi7MtK7AXFpOwDBNskqDmRTP1WdxB+a leaV19LqVURmEmw4Epxky4oW0YC6QKzNWb95tXBM2p9KLubnBR9JYsDIpwK0OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758482238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FxTThHbm7EyHQrZOIpcyAnh33A8o30JEiV4sxPXkFus=; b=Orm2byBYuPY2iqgyizQDodYv2JACD7Cx8pnyQ8YhBUWML4YHVwk8EZh6zYd69KQ2h7Gcrr eFYpSWgrzkxYFWiMLoc9UHfS//OQh2F3KR8hJc8EbYZ06CNELbcZVb5vsVzU2ob7Mlrooq B44wc4OGsnbp31HwabFscvr4txaPC7vC0/LyiABMdVftMeMCKWCbGT+QwEaPHp6hrsei9C wHK1yuLscO57d4HoLUQknX2CfNo8gtOnM6ncad6LNGAJyYAypcbbuVFU/QYDW8DuUOEMO+ M4SXWYusphYDIMkQTS5nHpqUW3vvm4rc/m16yaqU2L5fvc3apC00FJWCRFMZPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758482238; a=rsa-sha256; cv=none; b=OPqUyYxy2hc37RPDmCAnLO/XyTyad+jWsYmHe2Jvv/qBvccG5hWK/xzyuFtY1rkt4m7ArJ uZF7tkAjTlPZTZjbxyr1SD6KSYv89SgNcLoP/cSY0sSMiC3gqBpQSK2fqVTOZuvvWOEDBJ 4B9zpn0l8tCUl2DRF2l+fTp+KrJoBdH7hW/6T4QEfqOQCSwD2lL5Dp+dIsv79N62UhoTub Go/X6wXWDZdX89UkKhyk0BFwKh17sFvPFzdKO2Pjdd15llEWHC5hShlIH5b8JY09n9gbKH Wt0dSVHFfe7UULC18CNDhd21Ic/BomlHZ9xZ8WflffvV33pFebu0FwDprc8iOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2a01:e11:2002:4280:ab9b:8bf1:ec36:413a] (unknown [IPv6:2a01:e11:2002:4280:ab9b:8bf1:ec36:413a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cVGG55DlPzCrh; Sun, 21 Sep 2025 19:17:17 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <909b3e33-0639-4abc-915f-073cd0f304da@FreeBSD.org> Date: Sun, 21 Sep 2025 21:17:15 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 31ec8b6407fd - main - sys/netinet6: Implement RFC 7217 To: Gleb Smirnoff Cc: "Herbert J. Skuhra" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202509201231.58KCVqBC047480@gitrepo.freebsd.org> <874iswhip4.wl-herbert@gojira.at> <07503de1-785e-4e4d-b4e4-0524aeb064e1@FreeBSD.org> <87jz1sc9fr.wl-herbert@gojira.at> <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org> Content-Language: en-US From: Guido Falsi Autocrypt: addr=madpilot@FreeBSD.org; keydata= xsBNBE+G+l0BCADi/WBQ0aRJfnE7LBPsM0G3m/m3Yx7OPu4iYFvS84xawmRHtCNjWIntsxuX fptkmEo3Rsw816WUrek8dxoUAYdHd+EcpBcnnDzfDH5LW/TZ4gbrFezrHPdRp7wdxi23GN80 qPwHEwXuF0X4Wy5V0OO8B6VT/nA0ADYnBDhXS52HGIJ/GCUjgqJn+phDTdCFLvrSFdmgx4Wl c0W5Z1p5cmDF9l8L/hc959AeyNf7I9dXnjekGM9gVv7UDUYzCifR3U8T0fnfdMmS8NeI9NC+ wuREpRO4lKOkTnj9TtQJRiptlhcHQiAlG1cFqs7EQo57Tqq6cxD1FycZJLuC32bGbgalABEB AAHNIkd1aWRvIEZhbHNpIDxtYWRwaWxvdEBGcmVlQlNELm9yZz7CwHgEEwECACIFAk+G+3MC GwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEBrmhg5Wy9KT2uIIAIrawQ89TnqEhi2C OEQAhx3uqWZuNoS6NyiSgsRCmtSnT2GOgH4Ucbr/I37SkV1B3K6HkoL6lwN8Gjf5KOgLqmTi E1W3RTwS7l8PSvdnjM9i7g351R4mTijtxawB/JcQf/Kge3Yqr1V4g6H+wQXHUStmHThbupuN trzRphvR/e5ekT0FTyVfPmpcbm68i2bwZnKUex/TNIECBykYh8b+SYMLhENf2ayRjCIWS2Ad 7tnTKhMtnS5jtW6qjBy4RoTpQD6oR1xIgkTRlQ49roVCUfdHb+Y/kh+U9G1IcoNy4vkg9IfP dwpSfnP+a8j0AZ1hMnOLZ1fYoQrs+4gVLy8Fs7TOwU0EUxB7QQEQAKFhrDceoPdK/IHDSmoj 6SQYisvM7VdhcleS7E9DoEAVt7yMbf6HbbMVTTY6ckvwTWQssywLBXNVqxgc4WLJjzfUhgef +WE75M3+WFYlOVQLGZY/zEVgma1raYnOHNAOzeHLDmEXjbZP6vGAeDyBbGfQPpE7qGYZ7ube T3XwQO+PklcCrvOPj2ZPcAxGNS2xVU/LzONqCrJqLMJSIcCdsbiSP4G5PnDFHtMokaTY6OEr 8OEQfOAerhcHUa/z7Uu8YtmaqKH+QGkE/WEgaRqSiTnv0JOTD+DxehaqvoKPPZ++2NpCZMHB 2i6A/xifmQwEiIjEXtcueBRzkNUQkxhqZyS13SrhocL9ydtaVPBzZatAEjUDDEJmAMLVFs45 qfyhMiNapHJo2n3MW/E5omqCvEkDdWX/en3P7CK2TemeaDghMsgkNKax/z0wNo5UZCkOPOz0 xpNiUilOVbkuezZZNg65741qee2lfXhQIaZ66yT7hphc/N/z3PIAtLeze4u1VR2EXAuZ2sWA dlKCNTlJMsaU/x70BV11Wd/ypnVzM68dfdQIIAj1iMFAD/lXGlEUmKXg5Ov2VQDlTntQoanC YrAg+8CttPzjrydgLZFq3hrtQmfc0se5yv1WHS69+BsUOG09RvvawUDZxUjW19kyeN9THaNR gow3kSuArUp6zSmJABEBAAHCwF8EGAEIAAkFAlMQe0ECGwwACgkQGuaGDlbL0pMN5wgA4bCk X/qwEVC06ToeR6C2putmSWQMgpDaqrv65Hubo+QGmg2P4ewTYQQ4g6oYWS03qHxqVVWhKz7F jfrV+dH8qbCLfSgIcvdBha7ayGZVrsiuMLKGbw36fcmkZPpSDOfHcP0XH8Z+u9CWj0xUkTxA lZ/7i6gYSUpG2JWNtdmE/X8VVEyXusCLwy0K0BI60A/4dRTIX3C4QKrJ3ZbUXegz70ynjHf+ lQMZ9IZKASoRMuS5FozPQh6abvmwZEPdf5I9riUElzvHrqJ8Bx0t3Pujdoth+yNHpnBxrtO8 LkQdrQ58P0SwcaIX33T2U9pG8bhu5YVR88FQ8OQ0cEsPBpDncg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/21/25 20:56, Gleb Smirnoff wrote: > On Sun, Sep 21, 2025 at 06:02:24PM +0200, Guido Falsi wrote: > G> A C program would have included the system include and noticed the change, > G> but this software has hardcoded the struct in go code and requires > G> patching. > G> > G> I'm attaching a simple patch for the ports tree for this port, it compiles > G> but I've not tested it at runtime, could you try applying this patch to the > G> ports tree and recompile the port, and report back? > G> > G> Please note this is not a proper patch for the ports tree, it just fixes > G> the problem, but would break it for anyone else, I'll produce a proper > G> patch for the ports tree once I have confirmed the approach woks. > > Is struct nd_ifinfo something that is used as argument to ioctl(2)? > If so, then adding counter_u64_t into it is not correct. > > I would suggest to not revert the change as a whole, but remove the > counter only and bring struct nd_ifinfo back to original. The counter > should probably go into struct in6_ifextra that is pointed by > if->if_afdata[AF_INET6]. Thanks for the feedback and suggestion! You are definitely right! I'm in the process to create a review for such a change shortly, I'll post it as soon as I'm able to have the code tested. -- Guido Falsi