From owner-freebsd-current Thu May 25 20:36: 8 2000 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id B3EAF37B7CC for ; Thu, 25 May 2000 20:36:03 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id NAA11972; Fri, 26 May 2000 13:31:45 +1000 Date: Fri, 26 May 2000 13:31:39 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Poul-Henning Kamp Cc: Garrett Wollman , Jake Burkholder , Chuck Robey , FreeBSD-current Subject: Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h uthread_file.c src/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ... In-Reply-To: <6979.959290411@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 25 May 2000, Poul-Henning Kamp wrote: > In message , Bruce Evans > writes: > >I objected to a recent commit hiding the fact that this is > >"(elm)->field.sle_next". Anyway, curelm must be a pointer to a struct. > >Not just any struct; the struct must contain a "field" declared using > >SLIST_ENTRY(). > > It could be an union or class as well... It couldn't (usefully) be a union, because then there would be no space in the object for more than the list pointers. It would be a style bug for it to be a class, since if you have classes then you have C++ (or maybe objc) and then you should use C++ features and not cpp macro hacks to implement queue. It would be a style bug for it to be a typedef'ed struct type, since struct types shouldn't be typedefed (see style(9)). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message