Date: Thu, 15 Apr 2021 22:45:40 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: Mateusz Piotrowski <0mp@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: b3c7fff32af0 - main - sysutils/ansible-sshjail: New port Message-ID: <a5ec290d-f475-2cea-8903-fed118098adb@FreeBSD.org> In-Reply-To: <c07b643d-7b32-3d84-facf-04bf122ed1f7@FreeBSD.org> References: <202104151800.13FI0R3i033069@gitrepo.freebsd.org> <d7af612e-2b5d-b4b9-f534-bc30e42017b2@FreeBSD.org> <5ce76d1a-ca79-6e84-376b-612805f317b6@FreeBSD.org> <c07b643d-7b32-3d84-facf-04bf122ed1f7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15/04/21 22:39, Mateusz Piotrowski wrote: > Hi, > > On 15/04/2021 21:46, Guido Falsi wrote: >> On 15/04/21 21:07, Mateusz Piotrowski wrote: >>> >>>> diff --git a/sysutils/ansible-sshjail/Makefile >>>> b/sysutils/ansible-sshjail/Makefile >>>> new file mode 100644 >>>> index 000000000000..73499357b2f0 >>>> --- /dev/null >>>> +++ b/sysutils/ansible-sshjail/Makefile >>>> @@ -0,0 +1,30 @@ >>>> +PORTNAME= ansible-sshjail >>>> +DISTVERSION= 1.1.0-g20210107 >>> [snip] >>>> +GH_ACCOUNT= austinhyde >>>> +GH_TAGNAME= 981674f >>> Perhaps GH_TAGNAME could be replaced with DISTVERSION* variables based > on the output of git >>> describe --tags which is "v1.1.0-30-g981674f". >>> >> >> Is there a specific advantage to this approach? >> >> I did what I've been doing with other ports and also what I see >> documented in the porter's handbook. >> > There are a couple of advantages: > > 1. There is only one block of variables you need to edit in case of an > update. > > 2. DISTVERSION=1.1.0-30 becomes PORTVERSION=1.1.0.30. As a result, you > don't have to worry about increasing the date manually. Also, if you > happen to update the port twice to newer commit on a single day, you > don't have to come up with a workaround for 1.1.0-g20210107. The > DISTVERSION will just naturally increase from 1.1.0-30 to, e.g., 1.1.0-31. > > In fact, this is described in the FreeBSD Porter's Handbook in Example > 5.14. Using USE_GITHUB to Access a Commit Between Two Versions. The > gYYYYMMDD is reserved for cases when there is no single version tagged > by upstream (as explained in Example 5.13. Using USE_GITHUB When > Upstream Does Not Use Versions). > Ok you almost got me convinced, I'll do some testing and evaluate changing approach. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a5ec290d-f475-2cea-8903-fed118098adb>